Reverted boost::string_view back to boost::string_ref as it is not available in boost 1.58.0, required by Ubuntu Xenial (LTS)

Author: jgaa

include/restc-cpp/Url.h

@@ -3,7 +3,7 @@
 #ifndef RESTC_CPP_URL_H_
 #define RESTC_CPP_URL_H_
 
-#include <boost/utility/string_view.hpp>
+#include <boost/utility/string_ref.hpp>
 
 namespace restc_cpp {
 
@@ -20,19 +20,19 @@ namespace restc_cpp {
 
      Url& operator = (const char *url);
 
-     boost::string_view GetProtocolName() const { return protocol_name_; }
-     boost::string_view GetHost() const { return host_; }
-     boost::string_view GetPort() const { return port_; }
-     boost::string_view GetPath() const { return path_; }
-     boost::string_view GetArgs() const { return args_; }
+     boost::string_ref GetProtocolName() const { return protocol_name_; }
+     boost::string_ref GetHost() const { return host_; }
+     boost::string_ref GetPort() const { return port_; }
+     boost::string_ref GetPath() const { return path_; }
+     boost::string_ref GetArgs() const { return args_; }
      Protocol GetProtocol() const { return protocol_; }
 
  private:
-     boost::string_view protocol_name_;
-     boost::string_view host_;
-     boost::string_view port_;
-     boost::string_view path_ = "/";
-     boost::string_view args_;
+     boost::string_ref protocol_name_;
+     boost::string_ref host_;
+     boost::string_ref port_;
+     boost::string_ref path_ = "/";
+     boost::string_ref args_;
      Protocol protocol_ = Protocol::UNKNOWN;
  };
 

include/restc-cpp/url_encode.h

@@ -5,11 +5,11 @@
 
 #include "restc-cpp.h"
 
-#include <boost/utility/string_view.hpp>
+#include <boost/utility/string_ref.hpp>
 
 namespace restc_cpp {
 
-std::string url_encode(const boost::string_view& src);
+std::string url_encode(const boost::string_ref& src);
 
 } // namespace
 

src/Url.cpp

@@ -1,7 +1,7 @@
 #include <cassert>
 #include <array>
 
-#include <boost/utility/string_view.hpp>
+#include <boost/utility/string_ref.hpp>
 #include "restc-cpp/restc-cpp.h"
 #include "restc-cpp/Url.h"
 #include "restc-cpp/error.h"
@@ -28,18 +28,18 @@ Url& Url::operator = (const char *url) {
     constexpr auto magic_7 = 7;
 
     assert(url != nullptr && "A valid URL is required");
-    protocol_name_ = boost::string_view(url);
+    protocol_name_ = boost::string_ref(url);
     if (protocol_name_.find("https://") == 0) {
-        protocol_name_ = boost::string_view(url, magic_8);
+        protocol_name_ = boost::string_ref(url, magic_8);
         protocol_ = Protocol::HTTPS;
     } else if (protocol_name_.find("http://") == 0) {
-        protocol_name_ = boost::string_view(url, magic_7);
+        protocol_name_ = boost::string_ref(url, magic_7);
         protocol_ = Protocol::HTTP;
     } else {
         throw ParseException("Invalid protocol in url. Must be 'http[s]://'");
     }
 
-    auto remains = boost::string_view(protocol_name_.end());
+    auto remains = boost::string_ref(protocol_name_.end());
     const auto args_start = remains.find('?');
     if (args_start != string::npos) {
         args_ = {remains.begin() +  args_start + 1,
@@ -55,8 +55,8 @@ Url& Url::operator = (const char *url) {
         if (remains.length() <= static_cast<decltype(host_.length())>(port_start + 2)) {
             throw ParseException("Invalid host (no port after column)");
         }
-        //port_ = boost::string_view(&remains[port_start+1]);
-        //host_ = boost::string_view(host_.data(), port_start);
+        //port_ = boost::string_ref(&remains[port_start+1]);
+        //host_ = boost::string_ref(host_.data(), port_start);
         host_ = {remains.begin(), port_start};
         remains = {remains.begin() + port_start + 1, remains.size() - (port_start + 1)};
 

src/url_encode.cpp

@@ -35,7 +35,7 @@ allchars_t get_normal_ch() {
 
 } // anonymous namespace
 
-std::string url_encode(const boost::string_view& src) {
+std::string url_encode(const boost::string_ref& src) {
     constexpr auto magic_4 = 4;
     constexpr auto magic_0x0f = 0x0f;