Skip to content

Commit be7bbc1

Browse files
authored
Merge pull request #129 from jinyun1tang/jytang/taproots
bug fix for water balance
2 parents b3ffc0b + c2d8c07 commit be7bbc1

File tree

2 files changed

+2
-22
lines changed

2 files changed

+2
-22
lines changed

f90src/HydroTherm/SnowPhys/SnowBalanceMod.F90

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -119,26 +119,6 @@ subroutine SnowMassUpdate(I,J,NY,NX,QWatinfl2Mic,QHeatInfl2Soil)
119119
!
120120
! IF SNOWPACK DISAPPEARS
121121

122-
! intermediate disappearance
123-
IF(SoilBulkDensity_vr(NUM_col(NY,NX),NY,NX).LE.ZERO .or. SoilOrgM_vr(ielmc,0,NY,NX)<=1.e-2_r8)THEN
124-
VLWatMicP_vr(NUM_col(NY,NX),NY,NX) = VLWatMicP_vr(NUM_col(NY,NX),NY,NX)+QSnoWatXfer2Soil_col(NY,NX)
125-
VLiceMicP_vr(NUM_col(NY,NX),NY,NX) = VLiceMicP_vr(NUM_col(NY,NX),NY,NX)+QSnoIceXfer2Soil_col(NY,NX)
126-
127-
TKSX = TKS_vr(NUM_col(NY,NX),NY,NX)
128-
ENGY = VHeatCapacity_vr(NUM_col(NY,NX),NY,NX)*TKSX
129-
130-
VHeatCapacity_vr(NUM_col(NY,NX),NY,NX) = VHeatCapacitySoilM_vr(NUM_col(NY,NX),NY,NX) &
131-
+cpw*(VLWatMicP_vr(NUM_col(NY,NX),NY,NX)+VLWatMacP_vr(NUM_col(NY,NX),NY,NX)) &
132-
+cpi*(VLiceMicP_vr(NUM_col(NY,NX),NY,NX)+VLiceMacP_vr(NUM_col(NY,NX),NY,NX))
133-
134-
IF(VHeatCapacity_vr(NUM_col(NY,NX),NY,NX).GT.ZEROS(NY,NX) .and. abs(QSnoHeatXfer2Soil_col(NY,NX))>ZEROS(NY,NX))THEN
135-
TKS_vr(NUM_col(NY,NX),NY,NX) = (ENGY+QSnoHeatXfer2Soil_col(NY,NX))/VHeatCapacity_vr(NUM_col(NY,NX),NY,NX)
136-
ELSEIF(VHeatCapacity_vr(NUM_col(NY,NX),NY,NX).LE.ZEROS(NY,NX))then
137-
TKS_vr(NUM_col(NY,NX),NY,NX)=TairK_col(NY,NX)
138-
ENDIF
139-
140-
endif
141-
142122
call SnowpackDisapper(I,J,NY,NX,test_exist,QWatinfl2Mic_loc,QHeatInfl2Soil_loc)
143123

144124
if(test_exist)then

f90src/ModelDiags/BalancesMod.F90

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ subroutine EndCheckBalances(I,J,NHW,NHE,NVN,NVS)
234234
-HeatDrain_col(NY,NX)-HeatDischar_col(NY,NX)-HeatCanopy2Dist_col(NY,NX)
235235

236236
if(abs(WaterErr_test)>err_h2o .and. etimer%get_nstep()>1)then
237-
if(iVerbLevel==1)then
237+
if(iVerbLevel==1 .or. abs(SoilWatErr_test)>err_h2o)then
238238
write(110,*)('=',ii=1,50)
239239
write(110,*)I*1000+J,'NY,NX ',NY,NX
240240
write(110,*)'init H2O =',WaterErr_col(NY,NX)
@@ -273,7 +273,7 @@ subroutine EndCheckBalances(I,J,NHW,NHE,NVN,NVS)
273273
write(110,*)'SoilWatErr_test =',SoilWatErr_test
274274
write(110,*)'col WaterErr_test=',WaterErr_test
275275
endif
276-
if(abs(SoilWatErr_test)>1.e-4_r8 ) & ! .or. abs(SnowMassErr_test)>1.e-3_r8*SnowMassBeg_col(NY,NX)) &
276+
if(abs(SoilWatErr_test)>err_h2o ) & ! .or. abs(SnowMassErr_test)>1.e-3_r8*SnowMassBeg_col(NY,NX)) &
277277
call endrun('H2O error test failure in '//trim(mod_filename)//' at line',__LINE__)
278278

279279
endif

0 commit comments

Comments
 (0)