Skip to content

Commit ce311d1

Browse files
committed
chore(all): small tweaks
1 parent 057d6bb commit ce311d1

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

bulker/kafkabase/kafka_config.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,15 @@ type KafkaConfig struct {
4848
ProducerBatchSize int `mapstructure:"PRODUCER_BATCH_SIZE" default:"65535"`
4949
ProducerLingerMs int `mapstructure:"PRODUCER_LINGER_MS" default:"1000"`
5050
ProducerWaitForDeliveryMs int `mapstructure:"PRODUCER_WAIT_FOR_DELIVERY_MS" default:"1000"`
51-
51+
5252
// Failover logger configuration
5353
FailoverLoggerEnvConfig `mapstructure:",squash"`
5454
}
5555

5656
// GetKafkaConfig returns kafka config
5757
func (ac *KafkaConfig) GetKafkaConfig() *kafka.ConfigMap {
5858
if ac.KafkaBootstrapServers == "" {
59-
panic("❗️Kafka bootstrap servers are not set. Please set BULKER_KAFKA_BOOTSTRAP_SERVERS env variable")
59+
panic("❗️Kafka bootstrap servers are not set. Please set KAFKA_BOOTSTRAP_SERVERS env variable")
6060
}
6161
kafkaConfig := &kafka.ConfigMap{
6262
"client.id": "bulkerapp",

bulker/operator/operator.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -500,6 +500,8 @@ func (o *Operator) createDeploymentFromData(data *DeploymentData) error {
500500
// Create Service
501501
if err := o.createOrUpdateServiceFromData(ctx, data); err != nil {
502502
return fmt.Errorf("failed to create service: %v", err)
503+
} else {
504+
o.Infof("Service for deployment %s created/updated", data.DeploymentID)
503505
}
504506

505507
// Create HPA if enabled
@@ -585,6 +587,8 @@ func (o *Operator) updateDeploymentFromData(data *DeploymentData, existing *Depl
585587
// Update Service
586588
if err := o.createOrUpdateServiceFromData(ctx, data); err != nil {
587589
return fmt.Errorf("failed to update service: %v", err)
590+
} else {
591+
o.Infof("Service for deployment %s created/updated", data.DeploymentID)
588592
}
589593

590594
// Update HPA if enabled

services/rotor/build.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ esbuild
3939
format: "cjs",
4040
outfile: "./dist/functions-server.js",
4141
sourcemap: false,
42-
// minify: true,
42+
minify: true,
4343
external: externalModules,
4444
logLevel: "info",
4545
});

services/rotor/src/lib/retries.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ export function retryLogMessage(retryPolicy: retryPolicy, retries: number): stri
7171
export function retryObject(e: Error & { retryPolicy?: retryPolicy }, retries: number) {
7272
if (e.name === DropRetryErrorName || e.name === RetryErrorName) {
7373
const retryPolicy = getRetryPolicy(e);
74-
console.log("Retry policy: " + JSON.stringify(retryPolicy));
7574
const retryTime = retryBackOffTime(retryPolicy, retries + 1);
7675
return { retry: { left: retryPolicy.attempts - retries, ...(retryTime ? { time: retryTime } : {}) } };
7776
} else {

0 commit comments

Comments
 (0)