Skip to content

Make uid label configurable #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make uid label configurable #60

wants to merge 1 commit into from

Conversation

@iconoeugen
Copy link

@iconoeugen iconoeugen commented Aug 1, 2016

The uid is always using the sub value from the userinfo, which in some applications is not the expected value.

To avoid such limitations, the uid label is now configurable by configuring the omniauth uid_label option to a different label that apears in the userinfo details.

The default value for uid_label is set to sub to ensure the backward compatibility is not broken.

@iconoeugen
Make uid label configurable
ce277b4 
The uid is always using the sub value from the *userinfo*, which in some applications is not the expected value. To avoid such limitations, the uid label is now configurable by configuring the omniauth *uid_label* option to a different label that apears in the userinfo details. The default value for *uid_label* is set to *sub* to ensure the backward compatibility is not broken.
@coveralls
Copy link

coveralls commented Aug 1, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 99.475% when pulling ce277b4 on iconoeugen:feature/configurable_uid_label into 849b181 on jjbohn:master.

stanhu pushed a commit to stanhu/omniauth-openid-connect that referenced this pull request Apr 21, 2021
@ignatiusreza
bugfix: NoMethodError (undefined method `count' for #<OpenIDConnect::…
6398ad1 
…ResponseObject::IdToken:0x0000000008d9dde0>): (jjbohn#60)

since id_token gets decoded twice

fix jjbohn#59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iconoeugen @coveralls