remove unnecessary nil check - #546
Closed
celestix wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks! The always-true err==nil removal has landed (with credit), alongside a fix moving the dead LetsEncrypt warning into the branch where it was intended. Ships next release. |
jpillora
added a commit
that referenced
this pull request
Jul 16, 2026
- server_listen: move the LetsEncrypt port-443 warning into the hasDomains branch where it was intended (it was dead under hasKeyCert) and drop the always-true err==nil (PR #546) - fix user-facing 'forwaring' error (PRs #588/#575) and README .akp->.apk (PR #528); comment typos: represent, received, acquired, extracts, fairly straightforward, successfully, that's, doesn't - add codespell job to CI with .codespellrc (PR #430 idea), verified clean locally with codespell 2.4.2 Closes md task 25 Co-authored-by: celestix <celestix@users.noreply.github.com> Co-authored-by: edoardottt <edoardottt@users.noreply.github.com> Co-authored-by: iMarble <iMarble@users.noreply.github.com> Co-authored-by: mjtrangoni <mjtrangoni@users.noreply.github.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 48 already ensures that the error is nil in the listener function's scope afterwards therefore the error check is redundant.