Skip to content

Conversation

@benjagm
Copy link
Collaborator

@benjagm benjagm commented Jan 7, 2025

Summary

We are making it more clear for new contributors the conditions to work on an Issue and submit a PR.

@benjagm benjagm requested a review from a team as a code owner January 7, 2025 09:18
@github-actions
Copy link

github-actions bot commented Jan 7, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview cbc0f51

@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (72ae168) to head (cbc0f51).
⚠️ Report is 156 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1259   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjagm benjagm changed the title Update CONTRIBUTING.md for better guide new contributors Update CONTRIBUTING.md for better guidance for new contributors Jan 7, 2025
@gregsdennis
Copy link
Member

gregsdennis commented Jan 7, 2025

I also noticed that the triage process doesn't say anything about discussing solutions to identify the actions that need to take place. The status goes from "triage" to "available". I think there should be an "in discussion" step that indicates, "Yes this is a valid issue, but we're uncertain how we want to address it. Opinions are welcome."

@Relequestual
Copy link
Member

I think these changes are helpful.
What do you think about also modifying the PR template to add some comments which directs people to the contribution guide?

@benjagm
Copy link
Collaborator Author

benjagm commented Mar 4, 2025

Can we please merge this? @gregsdennis @Relequestual

@gregsdennis
Copy link
Member

The suggestions we made haven't been implemented.

@benjagm benjagm moved this to In Review Team in PR - Triage Group Mar 5, 2025
@benjagm benjagm moved this from In Review Team to Waiting for others to Review in PR - Triage Group Mar 5, 2025
@benjagm benjagm moved this from Waiting for others to Review to In Review Team in PR - Triage Group Mar 5, 2025
@benjagm benjagm moved this from In Review Team to Changes requested in PR - Triage Group May 30, 2025
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

Hello! 👋

This pull request has been automatically marked as stale due to inactivity 😴

It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details.

There can be many reasons why a specific pull request has no activity. The most probable cause is a lack of time, not a lack of interest.

Let us figure out together how to push this pull request forward. Connect with us through our slack channel : https://json-schema.org/slack

Thank you for your patience ❤️

@github-actions github-actions bot added the Status: Stale It's believed that this issue is no longer important to the requestor. label Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Stale It's believed that this issue is no longer important to the requestor.

Projects

Status: Changes requested

Development

Successfully merging this pull request may close these issues.

3 participants