Add autofocus for jwt token input #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiert-okta
changed the title
|
My main concern with this change is that the page doesn't follow a logical focus order. It might be an issue for accessibility or screen readers. @javiert-okta WDYT? |
Thanks for bringing this up @christiansamaniego-okta ! In fact, this does change the logical focus order which can be a problem for folks using screen readers. I would suggest adding a check option that lets a user trigger this autofocus functionality only if they want to. Some sort of personal preference that can be saved in the local storage. WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature for the user to enable or disable autofocus on JWT input.
This helps users who have reported they need to switch between tabs constantly to copy/paste tokens and use the mouse for manually focusing the input.
The new feature is optional, meaning the logical focus order won't be affected if the user doesn't want to
Light teme:
Dark theme