refactor: change views classes

Author: Juan Benitez

movies/models.py

@@ -1,12 +1,12 @@
 from django.db import models
 
- # Create Movie Model
+
 class Movie(models.Model):
     title = models.CharField(max_length=100)
     genre = models.CharField(max_length=100)
     year = models.IntegerField()
-    created_at = models.DateTimeField(auto_now_add=True) # When it was create
-    updated_at = models.DateTimeField(auto_now=True) # When i was update
+    created_at = models.DateTimeField(auto_now_add=True)
+    updated_at = models.DateTimeField(auto_now=True)
     creator = models.ForeignKey('auth.User', related_name='movies', on_delete=models.CASCADE)
 
 

movies/pagination.py

@@ -1,5 +1,6 @@
 from rest_framework.pagination import PageNumberPagination
 
+
 class CustomPagination(PageNumberPagination):
     page_size = 10
-    page_size_query_param = 'page_size'
+    page_size_query_param = 'page_size'

movies/permissions.py

@@ -15,16 +15,3 @@ def has_object_permission(self, request, view, obj):
 
         # Write permissions are only allowed to the creator of the movie
         return obj.creator == request.user
-
-
-class IsAuthenticated(permissions.BasePermission):
-    """
-    Allows access only to authenticated users.
-    """
-    def has_permission(self, request, view):
-        message = 'You must be authenticated'
-        is_it = bool(request.user and request.user.is_authenticated)
-        if is_it:
-            return is_it
-        else:
-            raise PermissionDenied(detail=message)

movies/serializers.py

@@ -11,7 +11,7 @@ class Meta:
         fields = ('id', 'title', 'genre', 'year', 'creator')
 
 
-class UserSerializer(serializers.ModelSerializer):  # create class to serializer usermodel
+class UserSerializer(serializers.ModelSerializer):  # create class to serializer user model
     movies = serializers.PrimaryKeyRelatedField(many=True, queryset=Movie.objects.all())
 
     class Meta:

movies/urls.py

@@ -1,14 +1,8 @@
-from django.urls import include, path, re_path
+from django.urls import path
 from . import views
 
 
 urlpatterns = [
-    re_path(r'^api/v1/movies/(?P<pk>[0-9]+)$', # Url to get update or delete a movie
-        views.get_delete_update_movie.as_view(),
-        name='get_delete_update_movie'
-    ),
-    path('api/v1/movies/', # urls list all and create new one
-        views.get_post_movies.as_view(),
-        name='get_post_movies'
-    )
+    path('', views.ListCreateMovieAPIView.as_view(), name='get_post_movies'),
+    path('<int:pk>/', views.RetrieveUpdateDestroyMovieAPIView.as_view(), name='get_delete_update_movie'),
 ]

movies/views.py

@@ -1,88 +1,29 @@
-from rest_framework import status
-from rest_framework.response import Response
 from rest_framework.generics import RetrieveUpdateDestroyAPIView, ListCreateAPIView
+from rest_framework.permissions import IsAuthenticated
 from .models import Movie
-from .permissions import IsOwnerOrReadOnly, IsAuthenticated
+from .permissions import IsOwnerOrReadOnly
 from .serializers import MovieSerializer
 from .pagination import CustomPagination
 
-class get_delete_update_movie(RetrieveUpdateDestroyAPIView):
-    serializer_class = MovieSerializer
-    permission_classes = (IsAuthenticated, IsOwnerOrReadOnly,)
-
-    def get_queryset(self, pk):
-        try:
-            movie = Movie.objects.get(pk=pk)
-        except Movie.DoesNotExist:
-            content = {
-                'status': 'Not Found'
-            }
-            return Response(content, status=status.HTTP_404_NOT_FOUND)
-        return movie
 
-    # Get a movie
-    def get(self, request, pk):
+class ListCreateMovieAPIView(ListCreateAPIView):
 
-        movie = self.get_queryset(pk)
-        serializer = MovieSerializer(movie)
-        return Response(serializer.data, status=status.HTTP_200_OK)
-
-    # Update a movie
-    def put(self, request, pk):
-        
-        movie = self.get_queryset(pk)
+    serializer_class = MovieSerializer
+    queryset = Movie.objects.all()
+    permission_classes = [IsAuthenticated]
+    pagination_class = CustomPagination
 
-        if(request.user == movie.creator): # If creator is who makes request
-            serializer = MovieSerializer(movie, data=request.data)
-            if serializer.is_valid():
-                serializer.save()
-                return Response(serializer.data, status=status.HTTP_201_CREATED)
-            return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
-        else:
-            content = {
-                'status': 'UNAUTHORIZED'
-            }
-            return Response(content, status=status.HTTP_401_UNAUTHORIZED)
+    def perform_create(self, serializer):
+        # Assign the user who created the movie
+        serializer.save(creator=self.request.user)
 
-    # Delete a movie
-    def delete(self, request, pk):
 
-        movie = self.get_queryset(pk)
+class RetrieveUpdateDestroyMovieAPIView(RetrieveUpdateDestroyAPIView):
+    serializer_class = MovieSerializer
+    queryset = Movie.objects.all()
+    permission_classes = [IsAuthenticated, IsOwnerOrReadOnly]
 
-        if(request.user == movie.creator): # If creator is who makes request
-            movie.delete()
-            content = {
-                'status': 'NO CONTENT'
-            }
-            return Response(content, status=status.HTTP_204_NO_CONTENT)
-        else:
-            content = {
-                'status': 'UNAUTHORIZED'
-            }
-            return Response(content, status=status.HTTP_401_UNAUTHORIZED)
-   
 
-class get_post_movies(ListCreateAPIView):
-    serializer_class = MovieSerializer
-    permission_classes = (IsAuthenticated,)
-    pagination_class = CustomPagination
-    
-    def get_queryset(self):
-       movies = Movie.objects.all()
-       return movies
 
-    # Get all movies
-    def get(self, request):
-        movies = self.get_queryset()
-        paginate_queryset = self.paginate_queryset(movies)
-        serializer = self.serializer_class(paginate_queryset, many=True)
-        return self.get_paginated_response(serializer.data)
 
-    # Create a new movie
-    def post(self, request):
-        serializer = MovieSerializer(data=request.data)
-        if serializer.is_valid():
-            serializer.save(creator=request.user)
-            return Response(serializer.data, status=status.HTTP_201_CREATED)
-        return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)