Merge pull request #336 from julia-vscode/sp/mutable-struct-const-bindings

Properly mark bindings for const-fields in mutable structs

Author: pfitzseb

src/bindings.jl

@@ -100,10 +100,9 @@ function mark_bindings!(x::EXPR, state)
         end
         mark_parameters(CSTParser.get_sig(x))
         if CSTParser.defines_struct(x) # mark field block
-            for i in 1:length(x.args[3].args)
-                CSTParser.defines_function(x.args[3].args[i]) && continue
-                arg = x.args[3].args[i]
-                if kwdef && CSTParser.isassignment(arg)
+            for arg in x.args[3].args
+                CSTParser.defines_function(arg) && continue
+                if kwdef && CSTParser.isassignment(arg) || arg.head === :const
                     arg = arg.args[1]
                 end
                 mark_binding!(arg)

test/runtests.jl

@@ -155,6 +155,17 @@ function f(arg::T)
 end
 """) == [true, true, true, true, true, true, true]
 
+        if VERSION > v"1.8-"
+            @test check_resolved("""
+            mutable struct T
+                const field
+            end
+            function f(arg::T)
+                arg.field
+            end
+            """) == [true, true, true, true, true, true, true]
+        end
+
         @test check_resolved("""
 f(arg) = arg
 """) == [1, 1, 1]