Merge branch 'main' of https://github.com/julianoczkowski/create-trimble-app

Author: julianoczkowski

.github/workflows/ci.yml

@@ -32,7 +32,8 @@ jobs:
         run: |
           test -f templates/react/package.json || exit 1
           test -f templates/angular/package.json || exit 1
-          echo "✓ Bundled templates verified"
+          test -f templates/solidjs/package.json || exit 1
+          echo "✓ Bundled templates verified (react, angular, solidjs)"
 
       - name: Test CLI commands
         run: |

.github/workflows/publish.yml

@@ -91,6 +91,13 @@ jobs:
           fi
           echo "✓ Angular bundled template exists"
 
+          # Check SolidJS template
+          if [ ! -f "templates/solidjs/package.json" ]; then
+            echo "Error: SolidJS bundled template not found"
+            exit 1
+          fi
+          echo "✓ SolidJS bundled template exists"
+
       - name: Run security audit
         run: npm audit --audit-level=high
 
@@ -136,9 +143,11 @@ jobs:
             - 🔒 No supply chain risks
 
             ### Features
+            - 🔍 **Prerequisites Check** - Verifies Git, Node.js 18+, npm with platform-specific install guides
             - 🎯 **Interactive CLI** - Beautiful interface with framework selection
             - ⚛️ **React** - React + Vite + Modus 2.0 Components
             - 🅰️ **Angular** - Angular + Modus 2.0 Web Components
+            - ▲ **SolidJS** - SolidJS + Vite + Modus 2.0 Components
             - 📦 **Smart Installation** - Package manager detection
             - 🔐 **Secure** - Published with npm provenance
 
@@ -162,11 +171,12 @@ jobs:
             ### CLI Options
             | Option | Description |
             |--------|-------------|
-            | `--framework <name>` | Specify framework (react, angular) |
+            | `--framework <name>` | Specify framework (react, angular, solidjs) |
             | `--current-folder` | Install in current directory |
             | `--dry-run` | Preview without making changes |
             | `--verbose` | Enable verbose output |
             | `--info` | Show CLI information |
             | `--no-install` | Skip dependency installation |
+            | `--skip-checks` | Skip prerequisite environment checks |
           draft: false
           prerelease: false

.github/workflows/template-validation.yml

@@ -0,0 +1,104 @@
+name: Template Validation
+
+on:
+  push:
+    branches: [main]
+    paths:
+      - 'templates/**'
+      - 'src/**'
+  pull_request:
+    branches: [main]
+    paths:
+      - 'templates/**'
+      - 'src/**'
+
+jobs:
+  validate-react:
+    name: React Template
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+
+      - name: Install CLI dependencies
+        run: npm ci
+
+      - name: Scaffold React app
+        run: node bin/create-trimble-app.js test-react-app --framework react --no-install
+
+      - name: Install template dependencies
+        working-directory: test-react-app
+        run: npm install
+
+      - name: Run template lint checks
+        working-directory: test-react-app
+        run: npm run lint:all
+
+      - name: Build template
+        working-directory: test-react-app
+        run: npm run build
+
+  validate-solidjs:
+    name: SolidJS Template
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+
+      - name: Install CLI dependencies
+        run: npm ci
+
+      - name: Scaffold SolidJS app
+        run: node bin/create-trimble-app.js test-solidjs-app --framework solidjs --no-install
+
+      - name: Install template dependencies
+        working-directory: test-solidjs-app
+        run: npm install
+
+      - name: Run template lint checks
+        working-directory: test-solidjs-app
+        run: npm run lint:all
+
+      - name: Build template
+        working-directory: test-solidjs-app
+        run: npm run build
+
+  validate-angular:
+    name: Angular Template
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: "npm"
+
+      - name: Install CLI dependencies
+        run: npm ci
+
+      - name: Scaffold Angular app
+        run: node bin/create-trimble-app.js test-angular-app --framework angular --no-install
+
+      - name: Install template dependencies
+        working-directory: test-angular-app
+        run: npm install
+
+      - name: Run template lint checks
+        working-directory: test-angular-app
+        run: npm run lint:all
+
+      - name: Build template
+        working-directory: test-angular-app
+        run: npm run build

.gitignore

@@ -98,6 +98,9 @@ pids
 *.swp
 *.swo
 
+# Nx cache
+.nx/
+
 # OS generated files
 .DS_Store
 .DS_Store?

CHANGELOG.md

@@ -9,6 +9,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+- **Prerequisites check** - CLI now verifies Git, Node.js (>= 18), and npm are available before scaffolding begins. Shows platform-specific install instructions (macOS: brew/Xcode CLT, Windows: winget, Linux: apt/dnf/pacman) if tools are missing
+- **GitHub account prompt** - Asks beginners if they have a GitHub account; if not, displays a guided signup panel with link and steps, then waits for confirmation before continuing. Automatically skipped in CI/non-TTY environments
+- **`--skip-checks` flag** - New CLI option to bypass prerequisite environment checks for experienced users
+- **Prerequisites test suite** - 18 new tests covering platform detection, version checks, install instruction generators, and GitHub signup info
+- **Post-scaffold validation** - CLI now runs `lint:all` after dependency installation to verify template integrity before the developer starts coding
+- **Template health report** - `TEMPLATE-HEALTH.md` auto-generated dashboard showing versions, component counts, lint script coverage, and status across all 3 templates. Run `node scripts/generate-template-health.js` to regenerate
+- **Template validation CI** - New `template-validation.yml` workflow that scaffolds, installs, lints, and builds all 3 templates on every PR touching `templates/` or `src/`
+- **Trimble Identity auth rules** - Cursor rules and commands for adding TID authentication to all 3 templates: React (`@trimble-oss/trimble-id-react`), SolidJS (embedded wrapper around `TIDClient`), and Angular (`@trimble-oss/trimble-id` core SDK with signals-based `AuthService`, functional guard, and HTTP interceptor)
 - **SolidJS Template** - New SolidJS + Vite + Modus 2.0 Components template
   - SolidJS 1.9.5 with `@solidjs/router` for client-side routing
   - Direct Modus web component integration (no wrapper library needed)
@@ -25,11 +33,37 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - GitHub Actions CI workflow
   - Code quality scripts (type-check, icon lint, semantic HTML, etc.)
 
+### Fixed
+
+- **Pre-commit hooks now block on failure** - All 3 templates: added `|| exit 1` to every check so failed lints actually prevent commits (previously hooks always exited 0)
+- **Pre-commit hooks run all checks** - React/SolidJS now run 8 checks (added `lint:opacity` and `lint:icon-names`), Angular runs 7
+- **`lint:all` runs all checks** - New `run-all-checks.js` script replaces `&&` chaining so all checks run even if some fail, with a summary table at the end
+- **SolidJS `<span>` in ModusTooltip** - Changed to `<div>` to pass `lint:semantic` (verified tooltip still works via Playwright)
+- **React `<span>` in ModusTooltip** - Same fix as SolidJS
+- **Inline styles false positive** - Fixed exclusion path from `src/pages/ColorPalettePage.tsx` to `src/dev-pages/**` in all templates
+- **SolidJS scripts said "Vite + React"** - All 8 scripts updated to say "Vite + SolidJS"
+- **SolidJS semantic HTML script suggested `className=`** - Fixed to suggest `class=` (SolidJS syntax)
+- **Angular semantic HTML script said "Vite + React"** - Fixed to say "Angular", suggestions use `class=`
+- **SolidJS GitHub instructions used React patterns** - Rewrote all 5 `.github/instructions/` files with SolidJS patterns (`createSignal`, `onMount`, `class=`, `Component` type, `@solidjs/router`)
+- **SolidJS CI missing from template verification** - Added `templates/solidjs/package.json` check to `ci.yml`
+
 ### Changed
 
+- CLI scaffold flow now starts with environment prerequisites before framework selection
 - CLI now supports three frameworks: React, Angular, and SolidJS
 - Framework validation updated to accept `solidjs` as a valid option
 - Updated CLI security notice and help text to list all three templates
+- CLI architecture now includes step 7 (post-scaffold validation) between dependency install and success message
+
+### Cursor Rules Updated (SolidJS)
+
+- `modus-checkbox-value-inversion-solidjs-short.mdc` - Wrapper prop is `value` not `checked`; use `onValueChange`
+- `modus-checkbox-value-inversion-solidjs.mdc` - Added "Use the Wrapper" section with correct API
+- `modus-navbar-side-navigation-solidjs-short.mdc` - Added navbar slots and SideNavigation flat-only limitation
+- `modus-navbar-side-navigation-solidjs.mdc` - Added custom sidebar guidance for hierarchical navigation
+- `modus-solidjs-integration-short.mdc` - Added "Common Wrapper Prop Gotchas" section
+- `modus-solidjs-essentials.mdc` - Added TextInput, SideNavigation, Table limitation sections
+- `modus-components-reference.mdc` - Added critical notes to Checkbox, TextInput, SideNavigation, Table entries
 
 ## [2.0.0] - 2026-01-28
 

CLAUDE.md

@@ -32,30 +32,35 @@ npm run prepublishOnly
 bin/create-trimble-app.js (entry point)
   └→ src/cli.js (Commander.js argument parsing)
       └→ src/scaffold.js (main orchestration)
+          ├→ src/utils/prerequisites.js (environment checks)
           ├→ src/frameworks.js (loads templates/config.json)
           └→ src/utils/* (file, git, install, logger)
 ```
 
 ### Key Modules
 
-**src/cli.js**: Parses CLI arguments with Commander.js. Validates framework option (react, angular, solidjs). Handles all CLI flags (--framework, --current-folder, --dry-run, --verbose, --info, --no-install). Checks for updates non-blocking.
+**src/cli.js**: Parses CLI arguments with Commander.js. Validates framework option (react, angular, solidjs). Handles all CLI flags (--framework, --current-folder, --dry-run, --verbose, --info, --no-install, --skip-checks). Checks for updates non-blocking.
 
 **src/scaffold.js**: Orchestrates the scaffolding flow:
-1. Framework selection (interactive or CLI arg)
-2. Installation location (current folder or new directory)
-3. Project name validation
-4. Dry-run preview (if enabled)
-5. Template copying
-6. package.json name update
-7. Dependency installation (optional)
-8. Success message
+1. Prerequisites check (Git, Node.js >= 18, npm — skippable with `--skip-checks`)
+2. GitHub account prompt (interactive only, skipped in CI/non-TTY)
+3. Framework selection (interactive or CLI arg)
+4. Installation location (current folder or new directory)
+5. Project name validation
+6. Dry-run preview (if enabled)
+7. Template copying
+8. package.json name update
+9. Dependency installation (optional)
+10. Success message
 
 **src/frameworks.js**: Loads `templates/config.json` and returns enabled frameworks. Filters out any with `disabled: true`. Provides `getFrameworkById()` lookup.
 
 **src/utils/file.js**: `validateProjectName()`, `updatePackageJson()`, `getCurrentFolderName()`
 
 **src/utils/git.js**: `copyTemplate()` copies from bundled `templates/` directory to target (local file copy, no git operations despite the filename). Skips `node_modules`, `dist`, `.angular`, `.git`, `coverage`, `.nyc_output` directories and lock files during copy. Renames `dot-npmrc` → `.npmrc` and `gitignore` → `.gitignore` (npm strips these during publish). `getDetailedErrorMessage()` transforms errors (EACCES, ENOSPC, etc.) into user-friendly messages.
 
+**src/utils/prerequisites.js**: `runPrerequisites()` checks the development environment before scaffolding: verifies Git is installed (with platform-specific install guide if missing for macOS/Windows/Linux), validates Node.js >= 18 (with nvm/fnm/nodejs.org upgrade instructions), confirms npm is available, and prompts about GitHub account (shows signup guide with boxen if needed). Skipped in CI/non-TTY mode for the GitHub prompt. All checks use `execa` with hardcoded arguments (no user input in commands). Exports individual check functions for testing.
+
 **src/utils/install.js**: Auto-detects package manager from lock files, runs install using execa.
 
 **src/utils/colors.js**: Trimble Brand Blue (#0063a3) with true color/256-color fallback via picocolors. All color functions used throughout the CLI.
@@ -68,6 +73,8 @@ Complete working projects in `templates/react/`, `templates/angular/`, and `temp
 
 `templates/config.json` defines framework metadata (name, description, badge, note) read by `src/frameworks.js`.
 
+All three templates include Trimble Identity (TID) authentication Cursor commands (`.cursor/commands/trimble-id.md`) and rules (`.cursor/rules/add-trimble-identity-auth.mdc`). React uses `@trimble-oss/trimble-id-react`, SolidJS wraps `TIDClient` in a SolidJS context, Angular uses `@trimble-oss/trimble-id` core SDK with signals-based `AuthService`, functional guard, and HTTP interceptor.
+
 #### SolidJS Template
 
 SolidJS 1.9 + Vite + TypeScript + Tailwind CSS 3 + @solidjs/router. Uses `@trimble-oss/moduswebcomponents` (vanilla web components, no React wrapper).
@@ -99,6 +106,7 @@ Vitest tests in `tests/`:
 - frameworks.test.js
 - utils/file.test.js
 - utils/git.test.js
+- utils/prerequisites.test.js
 
 30s timeout for integration tests. Coverage excludes src/cli.js.