Remove Base.vect override (#293)

Author: ericphanson

src/atoms/affine/stack.jl

@@ -130,10 +130,4 @@ function hvcat(rows::Tuple{Vararg{Int}}, args::AbstractExprOrValue...)
         a += rows[i]
     end
     return vcat(rs...)
-end
-
-Base.vect(args::AbstractExpr...) = transpose(HcatAtom(map(transpose, args)...))
-Base.vect(args::AbstractExprOrValue...) = transpose(HcatAtom(map(arg -> transpose(convert(AbstractExpr, arg)), args)...))
-
-# XXX: Reimplementation of the Base method
-Base.vect(args::Value...) = copyto!(Vector{Base.promote_typeof(args...)}(undef, length(args)), args)
+end

test/test_utilities.jl

@@ -88,6 +88,11 @@
         @test Convex.imag_conic_form(Constant([1.0, 2.0])) == [0.0, 0.0]
     end
 
+    @testset "Base.vect" begin
+    # Issue #223: ensure we can make vectors of variables
+    @test size([Variable(2), Variable(3,4)]) == (2,)
+    end
+
     @testset "Iteration" begin
         x = Variable(2,3)
         s = sum([xi for xi in x])