Skip to content
This repository was archived by the owner on Sep 3, 2024. It is now read-only.

Commit 9d4f2a3

Browse files
committed
coerce limit input value to Number, add number controls Fixes #45
(c) Copyright IBM Corp. 2016
1 parent 409a075 commit 9d4f2a3

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

urth-viz-explorer.html

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@
104104
<urth-core-dataframe
105105
ref$="{{ref}}"
106106
value="{{df}}"
107-
limit="{{limit}}"
108107
row-as-object="true"
109108
on-rows-changed="_rowsChanged"
110109
on-columns-changed="_selectDefaults"
@@ -129,7 +128,7 @@
129128
<paper-item name="circle">Scatter Chart</paper-item>
130129
</paper-listbox>
131130
</paper-dropdown-menu>
132-
<paper-input label="Limit" value="{{limit}}"></paper-input>
131+
<paper-input label="Limit" type="number" value="{{limit}}"></paper-input>
133132
</paper-card-collapse>
134133

135134
<!-- select viz properties -->
@@ -478,7 +477,15 @@
478477
Polymer.dom(this).appendChild(this.$$('urth-viz-query'));
479478

480479
// Call ready() directly to bind to new DOM document
481-
this.querySelector('urth-core-dataframe').ready();
480+
var dataframe = this.querySelector('urth-core-dataframe');
481+
dataframe.ready();
482+
483+
dataframe.limit = this.limit;
484+
485+
// Bind limit to dataframe, but coerce to Number
486+
this.addEventListener('limit-changed', function(event) {
487+
dataframe.limit = +event.detail.value;
488+
});
482489
});
483490
} else {
484491
// If no dataframe instance is specified with `ref`, look instead for a provided child dataframe
@@ -491,16 +498,18 @@
491498
// and set up properties and events
492499
dataframe.rowAsObject = true;
493500
dataframe.limit = this.limit;
494-
this.addEventListener('limit-changed', function(event) {
495-
dataframe.limit = event.detail.value;
496-
});
497501
dataframe.addEventListener('value-changed', this._dataChanged.bind(this));
498502
dataframe.addEventListener('columns-changed', function (event) {
499503
this.async(this._selectDefaults.bind(this, event));
500504
}.bind(this));
501505
dataframe.addEventListener('rows-changed', function(event) {
502506
this.async(this._rowsChanged.bind(this, event));
503507
}.bind(this));
508+
509+
// Bind limit to dataframe, but coerce to Number
510+
this.addEventListener('limit-changed', function(event) {
511+
dataframe.limit = +event.detail.value;
512+
});
504513
}
505514
}
506515
}

0 commit comments

Comments
 (0)