Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Commit 7487a0a

Browse files
committed
Fix some Scala and R warnings
(c) Copyright IBM Corp. 2016
1 parent c42d2cc commit 7487a0a

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

kernel-r/declarativewidgets/man/widgets-package.Rd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ Maintainer: \packageMaintainer{declarativewidgets}
2323
}
2424
\references{
2525
~~ Literature or other references for background information ~~
26-
}
2726
~~ Optionally other standard keywords, one per line, from file KEYWORDS in ~~
2827
~~ the R documentation directory ~~
28+
}
2929
\keyword{ package }
3030
\seealso{
3131
~~ Optional links to other man pages, e.g. ~~

kernel-scala/src/main/scala/declarativewidgets/query/QuerySupport.scala

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,16 @@ trait QuerySupport extends LogLike {
4242
val by = toColExpr(
4343
expr \ "by" match {
4444
case JsString(col) => List(col)
45-
case JsArray(colList:Seq[JsString]) => colList.map(_.as[String]).toList
45+
case JsArray(colList:Seq[_]) => colList.map(_.as[String]).toList
4646
case _ => Nil
4747
}
4848
)
4949

5050
val agg = toArrayOfFuncExpr(
5151
expr \ "agg" match {
5252
case anAgg:JsObject => List(anAgg)
53-
case JsArray(aggList:Seq[JsObject]) => aggList.map(_.as[JsObject]).toList
53+
case JsArray(aggList:Seq[_]) => aggList.map(_.as[JsObject]).toList
5454
case _ => List()
55-
5655
}
5756
)
5857
//rename resultant column names to dataframe format i.e. sum(columnName) -> sum_columnName
@@ -71,14 +70,14 @@ trait QuerySupport extends LogLike {
7170
val by = toColExpr(
7271
expr \ "by" match {
7372
case JsString(col) => List(col)
74-
case JsArray(colList:Seq[JsString]) => colList.map(_.as[String]).toList
73+
case JsArray(colList:Seq[_]) => colList.map(_.as[String]).toList
7574
case _ => Nil
7675
})
7776

7877
val ascending =
7978
expr \ "ascending" match {
8079
case JsBoolean(asc) => List(asc)
81-
case JsArray(ascList:Seq[JsBoolean]) => ascList.map(_.as[Boolean]).toList
80+
case JsArray(ascList:Seq[_]) => ascList.map(_.as[Boolean]).toList
8281
case _ => Nil
8382
}
8483

kernel-scala/src/main/scala/declarativewidgets/util/Explore.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ object Explore {
3737
def getDfNameFromLastExploreRequest(): String = {
3838
val executingRequest = getExecutingRequest()
3939
val requestTrees = executingRequest.map(_.trees.head.asInstanceOf[reflect.runtime.universe.Tree])
40-
val valDefTrees = requestTrees collect {case c: ValDef => c}
40+
val valDefTrees = requestTrees.map(_.asInstanceOf[ValDef])
4141
val exploreTrees = valDefTrees.filter({ eTree =>
4242
val children = eTree.rhs.children
4343
children.length > 0 && children.head.toString.equals("explore")

0 commit comments

Comments
 (0)