Skip to content

Commit 2e067f5

Browse files
authored
fix(deps): add rxjs>=7 as peer dependency to custom-esbuild, custom-webpack, and jest (fixes #1863) (#2188)
* fix(deps): add rxjs>=7 as peer dependency to custom-esbuild, custom-webpack, and jest All three packages import from 'rxjs' directly (switchMap, defer, from, Observable) but none declared it as a peer dependency. This caused runtime errors when a consumer project had rxjs@6 installed, which would shadow the v7 brought in transitively by @angular-devkit/architect. Fixes #1863 * chore: update yarn.lock with rxjs peer dep entries
1 parent a0daa6a commit 2e067f5

4 files changed

Lines changed: 8 additions & 2 deletions

File tree

packages/custom-esbuild/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
},
4747
"peerDependencies": {
4848
"@angular/compiler-cli": "^21.0.0",
49+
"rxjs": ">=7.0.0",
4950
"vitest": ">=2"
5051
},
5152
"devDependencies": {

packages/custom-webpack/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@
4848
"webpack-merge": "^6.0.0"
4949
},
5050
"peerDependencies": {
51-
"@angular/compiler-cli": "^21.0.0"
51+
"@angular/compiler-cli": "^21.0.0",
52+
"rxjs": ">=7.0.0"
5253
},
5354
"devDependencies": {
5455
"jest": "30.3.0",

packages/jest/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@
5252
"@angular/compiler-cli": "^21.0.0",
5353
"@angular/core": "^21.0.0",
5454
"@angular/platform-browser-dynamic": "^21.0.0",
55-
"jest": "^30.0.0"
55+
"jest": "^30.0.0",
56+
"rxjs": ">=7.0.0"
5657
},
5758
"devDependencies": {
5859
"@types/jest": "^30.0.0",

yarn.lock

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ __metadata:
218218
typescript: 5.9.3
219219
peerDependencies:
220220
"@angular/compiler-cli": ^21.0.0
221+
rxjs: ">=7.0.0"
221222
vitest: ">=2"
222223
languageName: unknown
223224
linkType: soft
@@ -239,6 +240,7 @@ __metadata:
239240
webpack-merge: ^6.0.0
240241
peerDependencies:
241242
"@angular/compiler-cli": ^21.0.0
243+
rxjs: ">=7.0.0"
242244
languageName: unknown
243245
linkType: soft
244246

@@ -263,6 +265,7 @@ __metadata:
263265
"@angular/core": ^21.0.0
264266
"@angular/platform-browser-dynamic": ^21.0.0
265267
jest: ^30.0.0
268+
rxjs: ">=7.0.0"
266269
languageName: unknown
267270
linkType: soft
268271

0 commit comments

Comments
 (0)