fix Informative error message at macro eval time for extra arguments #48

Author: jw3126

Project.toml

@@ -1,7 +1,7 @@
 name = "ArgCheck"
 uuid = "dce04be8-c92d-5529-be00-80e4d2c0e197"
 license = "MIT"
-version = "2.4.0"
+version = "2.4.1"
 
 [compat]
 julia = "1"

src/checks.jl

@@ -80,7 +80,7 @@ end
 See also [`@check`](@ref).
 """
 macro argcheck(ex, options...)
-    check(ex, ArgCheckFlavor(), options...)
+    checkmacro(ex, ArgCheckFlavor(), options...)
 end
 
 """
@@ -97,10 +97,13 @@ Usage is as follows:
 See also [`@argcheck`](@ref).
 """
 macro check(ex, options...)
-    check(ex, CheckFlavor(), options...)
+    checkmacro(ex, CheckFlavor(), options...)
 end
 
-function check(ex, checkflavor, options...)
+function checkmacro(ex, checkflavor, options...)
+    if length(options) > 1
+        error("Too many arguments for @check/@argcheck macro")
+    end
     codeflavor = if isexpr(ex, :comparison)
         ComparisonFlavor()
     elseif isexpr(ex, :call)

test/checks.jl

@@ -308,4 +308,10 @@ end
     @test Meta.isexpr(ArgCheck.LABEL_END_CHECK, :meta)
 end
 
+@testset "Informative error message at macro eval time for extra arguments #48" begin
+    # https://github.com/jw3126/ArgCheck.jl/issues/48
+    @test_throws "Too many arguments" @macroexpand( @argcheck 1 == 1 1.8 "That's good")
+    @test_throws "Too many arguments" @macroexpand( @argcheck 1 == 2 1.8 "That's good")
+end
+
 end#module