If we create the record like this, then it prevents Execution from leaking into the public-facing ScheduledExecution API.
@kagkarlsson any suggestion on this?

package com.github.kagkarlsson.scheduler;

import com.github.kagkarlsson.scheduler.exceptions.DataClassMismatchException;
import com.github.kagkarlsson.scheduler.exceptions.MissingRawDataException;
import com.github.kagkarlsson.scheduler.task.Execution;
import com.github.kagkarlsson.scheduler.task.TaskInstanceId;
import java.time.Instant;

@SuppressWarnings("rawtypes")
public record ScheduledExecution<DATA_TYPE>(
    Class<DATA_TYPE> dataClass,
    TaskInstanceId taskInstance,
    Instant executionTime,
    Instant lastSuccess,
    Instant lastFailure,
    int consecutiveFailures,
    boolean picked,
    String pickedBy,
    Object taskData) {

  static <T> ScheduledExecution<T> from(Class<T> dataClass, Execution execution) {
    return new ScheduledExecution<>(
        dataClass,
        execution.taskInstance,
        execution.executionTime,
        execution.lastSuccess,
        execution.lastFailure,
        execution.consecutiveFailures,
        execution.picked,
        execution.pickedBy,
        execution.taskInstance.getData());
  }

  public TaskInstanceId getTaskInstance() {
    return taskInstance;
  }

  public Instant getExecutionTime() {
    return executionTime;
  }

  @SuppressWarnings("unchecked")
  public DATA_TYPE getData() {
    if (taskData == null) {
      return null;
    } else if (dataClass.isInstance(taskData)) {
      return (DATA_TYPE) taskData;
    }
    throw new DataClassMismatchException(dataClass, taskData.getClass());
  }

  public boolean hasRawData() {
    return taskData == null || taskData.getClass().equals(byte[].class);
  }

  public byte[] getRawData() {
    if (!hasRawData()) {
      throw new MissingRawDataException(dataClass);
    }
    return (byte[]) taskData;
  }

  public Instant getLastSuccess() {
    return lastSuccess;
  }

  public Instant getLastFailure() {
    return lastFailure;
  }

  public int getConsecutiveFailures() {
    return consecutiveFailures;
  }

  public boolean isPicked() {
    return picked;
  }

  public String getPickedBy() {
    return pickedBy;
  }
}

Uh oh!

refactor: change SchedulerExecution to not expose Execution (via constructor) #810

Description

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions