Remove unused parameters from condRepeatExprHeader and document condRepeatExprHeader and condRepeatExprFooter

Author: Mingun

shared/src/main/scala/io/kaitai/struct/languages/CSharpCompiler.scala

@@ -300,8 +300,8 @@ class CSharpCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
     out.puts("}")
   }
 
-  override def condRepeatExprHeader(id: Identifier, io: String, dataType: DataType, repeatExpr: expr): Unit = {
-    out.puts(s"for (var i = 0, _end = ${expression(repeatExpr)}; i < _end; ++i)")
+  override def condRepeatExprHeader(countExpr: expr): Unit = {
+    out.puts(s"for (var i = 0, _end = ${expression(countExpr)}; i < _end; ++i)")
     out.puts("{")
     out.inc
   }

shared/src/main/scala/io/kaitai/struct/languages/CppCompiler.scala

@@ -591,8 +591,8 @@ class CppCompiler(
     outSrc.puts("}")
   }
 
-  override def condRepeatExprHeader(id: Identifier, io: String, dataType: DataType, repeatExpr: Ast.expr): Unit = {
-    outSrc.puts(s"for (int i = 0, _end = ${expression(repeatExpr)}; i < _end; ++i) {")
+  override def condRepeatExprHeader(countExpr: Ast.expr): Unit = {
+    outSrc.puts(s"for (int i = 0, _end = ${expression(countExpr)}; i < _end; ++i) {")
     outSrc.inc
   }
 

shared/src/main/scala/io/kaitai/struct/languages/GoCompiler.scala

@@ -320,8 +320,8 @@ class GoCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
     out.puts(s"$name = append($name, $expr)")
   }
 
-  override def condRepeatExprHeader(id: Identifier, io: String, dataType: DataType, repeatExpr: Ast.expr): Unit = {
-    out.puts(s"for i, _end := 0, int(${expression(repeatExpr)}); i < _end; i++ {")
+  override def condRepeatExprHeader(countExpr: Ast.expr): Unit = {
+    out.puts(s"for i, _end := 0, int(${expression(countExpr)}); i < _end; i++ {")
     out.inc
     // FIXME: Go throws a fatal compile error when the `i` variable is not used (unused variables
     // can only use the blank identifier `_`, see https://go.dev/doc/effective_go#blank), so we have

shared/src/main/scala/io/kaitai/struct/languages/JavaCompiler.scala

@@ -377,8 +377,8 @@ class JavaCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
     out.puts("}")
   }
 
-  override def condRepeatExprHeader(id: Identifier, io: String, dataType: DataType, repeatExpr: expr): Unit = {
-    out.puts(s"for (int i = 0, _end = ${expression(repeatExpr)}; i < _end; ++i) {")
+  override def condRepeatExprHeader(countExpr: expr): Unit = {
+    out.puts(s"for (int i = 0, _end = ${expression(countExpr)}; i < _end; ++i) {")
     out.inc
 
     importList.add("java.util.ArrayList")

shared/src/main/scala/io/kaitai/struct/languages/JavaScriptCompiler.scala

@@ -319,8 +319,8 @@ class JavaScriptCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
     out.puts("}")
   }
 
-  override def condRepeatExprHeader(id: Identifier, io: String, dataType: DataType, repeatExpr: expr): Unit = {
-    out.puts(s"for (var i = 0, _end = ${expression(repeatExpr)}; i < _end; ++i) {")
+  override def condRepeatExprHeader(countExpr: expr): Unit = {
+    out.puts(s"for (var i = 0, _end = ${expression(countExpr)}; i < _end; ++i) {")
     out.inc
   }
 

shared/src/main/scala/io/kaitai/struct/languages/LuaCompiler.scala

@@ -181,8 +181,8 @@ class LuaCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
     out.puts("end")
   }
 
-  override def condRepeatExprHeader(id: Identifier, io: String, dataType: DataType, repeatExpr: Ast.expr): Unit = {
-    out.puts(s"for i = 0, ${expression(repeatExpr)} - 1 do")
+  override def condRepeatExprHeader(countExpr: Ast.expr): Unit = {
+    out.puts(s"for i = 0, ${expression(countExpr)} - 1 do")
     out.inc
   }
   override def condRepeatExprFooter: Unit = {

shared/src/main/scala/io/kaitai/struct/languages/NimCompiler.scala

@@ -167,8 +167,8 @@ class NimCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
     out.dec
     out.dec
   }
-  override def condRepeatExprHeader(id: Identifier, io: String, dataType: DataType, repeatExpr: Ast.expr): Unit = {
-    out.puts(s"for i in 0 ..< int(${expression(repeatExpr)}):")
+  override def condRepeatExprHeader(countExpr: Ast.expr): Unit = {
+    out.puts(s"for i in 0 ..< int(${expression(countExpr)}):")
     out.inc
   }
   override def condRepeatUntilHeader(itemType: DataType): Unit = {

shared/src/main/scala/io/kaitai/struct/languages/PHPCompiler.scala

@@ -297,8 +297,8 @@ class PHPCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
     super.condRepeatEosFooter
   }
 
-  override def condRepeatExprHeader(id: Identifier, io: String, dataType: DataType, repeatExpr: Ast.expr): Unit = {
-    out.puts(s"$$n = ${expression(repeatExpr)};")
+  override def condRepeatExprHeader(countExpr: Ast.expr): Unit = {
+    out.puts(s"$$n = ${expression(countExpr)};")
     out.puts("for ($i = 0; $i < $n; $i++) {")
     out.inc
   }

shared/src/main/scala/io/kaitai/struct/languages/PerlCompiler.scala

@@ -254,8 +254,8 @@ class PerlCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
   override def handleAssignmentRepeatEos(id: Identifier, expr: String): Unit =
     out.puts(s"push @{${privateMemberName(id)}}, $expr;")
 
-  override def condRepeatExprHeader(id: Identifier, io: String, dataType: DataType, repeatExpr: expr): Unit = {
-    out.puts(s"for (my $$i = 0, $$_end = ${expression(repeatExpr)}; $$i < $$_end; ++$$i) {")
+  override def condRepeatExprHeader(countExpr: expr): Unit = {
+    out.puts(s"for (my $$i = 0, $$_end = ${expression(countExpr)}; $$i < $$_end; ++$$i) {")
     out.inc
   }
 

shared/src/main/scala/io/kaitai/struct/languages/PythonCompiler.scala

@@ -313,8 +313,8 @@ class PythonCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
     universalFooter
   }
 
-  override def condRepeatExprHeader(id: Identifier, io: String, dataType: DataType, repeatExpr: expr): Unit = {
-    out.puts(s"for i in range(${expression(repeatExpr)}):")
+  override def condRepeatExprHeader(countExpr: expr): Unit = {
+    out.puts(s"for i in range(${expression(countExpr)}):")
     out.inc
   }
   override def handleAssignmentRepeatExpr(id: Identifier, expr: String): Unit =