Skip to content

Commit f15131e

Browse files
committed
Remove unused parameters from condRepeatEosHeader and document condRepeatEosHeader and condRepeatEosFooter
1 parent 39c9d3b commit f15131e

File tree

14 files changed

+24
-20
lines changed

14 files changed

+24
-20
lines changed

shared/src/main/scala/io/kaitai/struct/languages/CSharpCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ class CSharpCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
280280
out.puts(s"${privateMemberName(id)} = new ${kaitaiType2NativeType(ArrayTypeInStream(dataType))}();")
281281
}
282282

283-
override def condRepeatEosHeader(id: Identifier, io: String, dataType: DataType): Unit = {
283+
override def condRepeatEosHeader(io: String): Unit = {
284284
out.puts("{")
285285
out.inc
286286
out.puts("var i = 0;")

shared/src/main/scala/io/kaitai/struct/languages/CppCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ class CppCompiler(
571571
outSrc.puts(s"${privateMemberName(id)} = ${newVector(dataType)};")
572572
}
573573

574-
override def condRepeatEosHeader(id: Identifier, io: String, dataType: DataType): Unit = {
574+
override def condRepeatEosHeader(io: String): Unit = {
575575
outSrc.puts("{")
576576
outSrc.inc
577577
outSrc.puts("int i = 0;")

shared/src/main/scala/io/kaitai/struct/languages/GoCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ class GoCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
300300
// function works even on `nil` slices (https://go.dev/tour/moretypes/15)
301301
}
302302

303-
override def condRepeatEosHeader(id: Identifier, io: String, dataType: DataType): Unit = {
303+
override def condRepeatEosHeader(io: String): Unit = {
304304
out.puts(s"for i := 0;; i++ {")
305305
out.inc
306306

shared/src/main/scala/io/kaitai/struct/languages/JavaCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ class JavaCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
355355
override def condRepeatInitAttr(id: Identifier, dataType: DataType): Unit =
356356
out.puts(s"${privateMemberName(id)} = new ${kaitaiType2JavaType(ArrayTypeInStream(dataType))}();")
357357

358-
override def condRepeatEosHeader(id: Identifier, io: String, dataType: DataType): Unit = {
358+
override def condRepeatEosHeader(io: String): Unit = {
359359
out.puts("{")
360360
out.inc
361361
out.puts("int i = 0;")

shared/src/main/scala/io/kaitai/struct/languages/JavaScriptCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ class JavaScriptCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
303303
override def condRepeatInitAttr(id: Identifier, dataType: DataType): Unit =
304304
out.puts(s"${privateMemberName(id)} = [];")
305305

306-
override def condRepeatEosHeader(id: Identifier, io: String, dataType: DataType): Unit = {
306+
override def condRepeatEosHeader(io: String): Unit = {
307307
out.puts("var i = 0;")
308308
out.puts(s"while (!$io.isEof()) {")
309309
out.inc

shared/src/main/scala/io/kaitai/struct/languages/LuaCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ class LuaCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
170170
out.puts(s"${privateMemberName(id)} = {}")
171171
}
172172

173-
override def condRepeatEosHeader(id: Identifier, io: String, dataType: DataType): Unit = {
173+
override def condRepeatEosHeader(io: String): Unit = {
174174
out.puts("local i = 0")
175175
out.puts(s"while not $io:is_eof() do")
176176
out.inc

shared/src/main/scala/io/kaitai/struct/languages/NimCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ class NimCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
155155
// empty sequences (see https://narimiran.github.io/nim-basics/#_result_variable)
156156
}
157157

158-
override def condRepeatEosHeader(id: Identifier, io: String, dataType: DataType): Unit = {
158+
override def condRepeatEosHeader(io: String): Unit = {
159159
out.puts("block:")
160160
out.inc
161161
out.puts("var i: int")

shared/src/main/scala/io/kaitai/struct/languages/PHPCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ class PHPCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
282282
override def condRepeatInitAttr(id: Identifier, dataType: DataType): Unit =
283283
out.puts(s"${privateMemberName(id)} = [];")
284284

285-
override def condRepeatEosHeader(id: Identifier, io: String, dataType: DataType): Unit = {
285+
override def condRepeatEosHeader(io: String): Unit = {
286286
out.puts("$i = 0;")
287287
out.puts(s"while (!$io->isEof()) {")
288288
out.inc

shared/src/main/scala/io/kaitai/struct/languages/PerlCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ class PerlCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
246246
override def condRepeatInitAttr(id: Identifier, dataType: DataType): Unit =
247247
out.puts(s"${privateMemberName(id)} = [];")
248248

249-
override def condRepeatEosHeader(id: Identifier, io: String, dataType: DataType): Unit = {
249+
override def condRepeatEosHeader(io: String): Unit = {
250250
// Perl allows shadowing of variables, no need a scope to isolate them
251251
out.puts("my $i = 0;")
252252
out.puts(s"while (!$io->is_eof()) {")

shared/src/main/scala/io/kaitai/struct/languages/PythonCompiler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ class PythonCompiler(typeProvider: ClassTypeProvider, config: RuntimeConfig)
300300
override def condRepeatInitAttr(id: Identifier, dataType: DataType): Unit =
301301
out.puts(s"${privateMemberName(id)} = []")
302302

303-
override def condRepeatEosHeader(id: Identifier, io: String, dataType: DataType): Unit = {
303+
override def condRepeatEosHeader(io: String): Unit = {
304304
out.puts("i = 0")
305305
out.puts(s"while not $io.is_eof():")
306306
out.inc

0 commit comments

Comments
 (0)