Potential unhandled hash collisions

[Gattag]

It appears that you cache a data structure based on hashing but do not check for hash collisions, this looks like sneaky bug to me.

The following is in the SourceLocation companion:
introspekt-runtime/src/commonMain/kotlin/dev/karmakrafts/introspekt/util/SourceLocation.kt

        /**
         * Gets an existing [SourceLocation] from the cache or creates a new one if it doesn't exist.
         *
         * This method helps reduce memory usage by reusing instances with the same parameters.
         *
         * @param module The module name.
         * @param file The file name.
         * @param line The line number.
         * @param column The column number.
         * @return A [SourceLocation] instance with the specified parameters.
         */
        @IntrospektCompilerApi
        internal fun getOrCreate(module: String, file: String, line: Int, column: Int): SourceLocation {
            return cache.getOrPut(hash(module, file, line, column)) {
                SourceLocation( // @formatter:off
                    module = module,
                    file = file,
                    line = line,
                    column = column
                ) // @formatter:on
            }
        }

[KitsuneAlex]

Thank you for reporting, but what exactly in the snippet are you referring to? Are you referring to how hash is implemented?

[KitsuneAlex]

Okay i think i understand what you mean. I should use a data class as key type so i can let the HashMap handle collissions for me :) You are absolutely right here.

[KitsuneAlex]

Now i'm starting to question if caching these is worth it all..
SourceLocationKey would have the same fields as the value making it kinda worthless.
I think imma ditch caching for SourceLocation and use data class key types for everything that's more complex than its key.

[Gattag]

Now i'm starting to question if caching these is worth it all.. SourceLocationKey would have the same fields as the value making it kinda worthless. I think imma ditch caching for SourceLocation and use data class key types for everything that's more complex than its key.

Yeah I would ditch caching completely, unless you've seen or heard of a noticeable impact due to GC collections.