-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Currently KBR is hard coded but the issuer of the script should be configurable.
It should be configurable which fields of the XML request should be added to the CSV report (and with which column name).
request-isni/request_isni/lib.py
Lines 142 to 144 in 281612b
| result['KBRID'] = request.find('identityInformation/requestorIdentifierOfIdentity/identifier').text | |
| result['surname'] = request.find('identityInformation/identity/personOrFiction/personalName/surname').text | |
| result['forename'] = request.find('identityInformation/identity/personOrFiction/personalName/forename').text |
Additionally, ISNI XML responses have the response possibleMatch and if the match is with an identifier from us, we distinguish a possibleMatchDuplicateKBR response. This should also be configurable for non KBR data.
request-isni/request_isni/lib.py
Lines 94 to 100 in 281612b
| otherKBRRecord = True if isniNotAssigned.find('possibleMatch/source').text.startswith('KBR') else False | |
| if otherKBRRecord: | |
| result['isniStatus'] = 'possibleMatchDuplicateKBRID' | |
| result['PPN'] = isniNotAssigned.find('possibleMatch/PPN').text | |
| else: | |
| result['isniStatus'] = 'possibleMatch' | |
| result['PPN'] = isniNotAssigned.find('possibleMatch/PPN').text |
Metadata
Metadata
Assignees
Labels
No labels