feat(http-add-on): Add appProtocol support for interceptor admin and TLS service ports#829
Conversation
a9807b9 to
ea1d3ee
Compare
|
@JorTurFer @zroubalik — updated this PR to also cover the admin service (port name + appProtocol), regenerated docs with helm-docs, and squashed into a single DCO-signed commit. Would appreciate a review when you get a chance! |
|
Hi @gyanesh-mishra , I have two questions/notes:
|
ea1d3ee to
de37dfb
Compare
|
Thanks for the review @linkvt! On point 1 (appProtocol vs portName): You're right that That said, if you'd prefer to keep the surface area smaller, I'm happy to reduce this PR to just On point 2 (generic comments): Agreed! I've updated the comments to remove the Istio-specific links — they now just say "Useful for service mesh protocol selection" with example values. Pushed the update just now. |
|
Hi @gyanesh-mishra , I understand but would prefer to limit this change for now to the appProtocol fields, I'm a big fan of YAGNI 🙂 Thanks already for the change of the description! |
de37dfb to
b072697
Compare
3f22d7a to
c86a6c3
Compare
|
Thanks @linkvt! Updated the PR to drop all
Made |
…TLS service ports Add interceptor.admin.appProtocol and interceptor.tls.appProtocol Helm values to allow explicit protocol specification for service meshes. The proxy service already supported interceptor.proxy.appProtocol; this mirrors that for the admin and TLS ports. The proxy and TLS ports are intentionally independent: proxy.appProtocol applies only to the plain HTTP port, tls.appProtocol only to the TLS port, as they typically require different values (e.g. "http" vs "https"). Signed-off-by: Gyanesh Mishra <gyanesh.mishra@rubrik.com>
Signed-off-by: Vincent Link <vlink@redhat.com>
c86a6c3 to
fc072fa
Compare
|
Hi @gyanesh-mishra , thanks the changes look good! |
|
CI failure is unrelated and caused by the merge of kedacore/http-add-on#1532 - this will be handled in #835 |
|
Thank you! |
Add configurable
appProtocolfor the interceptor's admin and TLS service ports.Closes #828
Changes
New Helm Values
interceptor.admin.appProtocol""interceptor.tls.appProtocol""interceptor.proxy.appProtocolalready existed — no changes there.Template Changes
templates/interceptor/service-admin.yaml— adds optionalappProtocolfieldtemplates/interceptor/service-proxy.yaml— adds optionalappProtocolfield for the TLS port, independent ofproxy.appProtocolDocumentation
README.mdregenerated withhelm-docsBackward Compatibility
Default empty values maintain current behavior. Note:
proxy.appProtocolno longer implicitly applies to the TLS port — the two ports are now independently controlled.Checklist
Fixes #828