feat(http-add-on): add InterceptorRoute CRD and update RBAC permissions - #839
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for the new InterceptorRoute custom resource to the http-add-on Helm chart by shipping its CRD and extending RBAC so the operator/interceptor/scaler (and optional aggregate roles) can access it.
Changes:
- Add
InterceptorRouteCRD to the chart’s CRD template (guarded bycrds.install) - Extend operator/interceptor/scaler RBAC rules to include
interceptorroutes(plus/statusand/finalizersfor operator) - Update chart README text for
crds.installto mention both CRDs
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| http-add-on/templates/crd.yaml | Adds the InterceptorRoute CRD alongside the existing HTTPScaledObject CRD under the same install gate. |
| http-add-on/templates/operator/rbac.yml | Grants operator permissions for interceptorroutes, including status/finalizers management. |
| http-add-on/templates/interceptor/rbac.yml | Allows interceptor to get/list/watch interceptorroutes. |
| http-add-on/templates/scaler/rbac.yml | Allows scaler to get/list/watch interceptorroutes. |
| http-add-on/templates/rbac-aggregateclusterroles.yaml | Extends aggregated edit/view roles to include interceptorroutes. |
| http-add-on/README.md | Updates the crds.install description to reference both CRDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi, thanks for the PR, looks great in general, passing CI also is a good sign! Besides the issue copilot found, could you also update CI for InterceptorRoute? I'm fine with having both the HTTPSO and IR checks for now with a TODO to remove them or so, see https://github.com/kedacore/charts/blob/main/.github/workflows/ci-http-add-on.yml |
|
Thanks! Updated CI for InterceptorRoute as requested, addressed the Copilot findings, and added additional RBAC validation steps to the workflow. |
|
Hi @AtharvaPakade , thanks! I noticed you added quite elaborative RBAC checks compared to the simple get and describe used for the HTTPSO - was that on purpose? Not sure if the detailed check has a benefit over a simple one for Helm Chart validation. |
|
@linkvt The component's operation depends on its ability to list those items, so I thought the extra validation was worthwhile. Happy to simplify it to basic get/describe if you'd prefer to keep the CI lighter! |
|
Yes I think we can keep it as simple as before, where it just verifies that the CRD is there and can be used in theory 👍 |
… validation Signed-off-by: Atharva Pakade <pakade310@gmail.com>
Provide a description of what has been changed
Adds the InterceptorRoute CRD to the http-add-on Helm chart and extends RBAC permissions for the
operator, interceptor, scaler, and aggregate cluster roles to manage the new resource.
Test checklist:
Checklist
Fixes #835
cc @linkvt