bpf: Free special fields when update [lru_,]percpu_hash maps #6298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 4cb4897 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c95b89c to
828eff8
Compare
Author
|
Upstream branch: b54a8e1 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
82bd1da to
d27b83c
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
828eff8 to
03f9e36
Compare
Author
|
Upstream branch: b54a8e1 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
d27b83c to
dfc07c8
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
03f9e36 to
97961e6
Compare
Author
|
Upstream branch: 6f1f4c1 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
dfc07c8 to
a198e21
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
97961e6 to
2456350
Compare
Author
|
Upstream branch: f8c67d8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
a198e21 to
9a9e418
Compare
Author
|
Upstream branch: f8c67d8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
9a9e418 to
476562c
Compare
Return -ETIMEDOUT whenever non-head waiters are signalled by head, and fix oversight in commit 7bd6e5c ("rqspinlock: Disable queue destruction for deadlocks"). We no longer signal on deadlocks. Signed-off-by: Kumar Kartikeya Dwivedi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexei Starovoitov <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
2456350 to
4eb9670
Compare
As [lru_,]percpu_hash maps support BPF_KPTR_{REF,PERCPU}, missing
calls to 'bpf_obj_free_fields()' in 'pcpu_copy_value()' could cause the
memory referenced by BPF_KPTR_{REF,PERCPU} fields to be held until the
map gets freed.
Fix this by calling 'bpf_obj_free_fields()' after
'copy_map_value[,_long]()' in 'pcpu_copy_value()'.
Fixes: 65334e6 ("bpf: Support kptrs in percpu hashmap and percpu LRU hashmap")
Signed-off-by: Leon Hwang <[email protected]>
Acked-by: Yonghong Song <[email protected]>
…ate [lru_,]percpu_hash maps Add test to verify that updating [lru_,]percpu_hash maps decrements refcount when BPF_KPTR_REF objects are involved. The tests perform the following steps: 1. Call update_elem() to insert an initial value. 2. Use bpf_refcount_acquire() to increment the refcount. 3. Store the node pointer in the map value. 4. Add the node to a linked list. 5. Probe-read the refcount and verify it is *2*. 6. Call update_elem() again to trigger refcount decrement. 7. Probe-read the refcount and verify it is *1*. Signed-off-by: Leon Hwang <[email protected]> Acked-by: Yonghong Song <[email protected]>
Author
|
Upstream branch: 026bcf9 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1019940=>bpf-next
branch
from
476562c to
5bb4bc1
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4eb9670 to
e1b05fd
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1019940 irrelevant now. Closing PR. |
kernel-patches-daemon-bpf-rc
bot
deleted the
series/1019940=>bpf-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Free special fields when update [lru_,]percpu_hash maps
version: 6
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1019940