Skip to content

Commit 6d69b41

Browse files
authored
refactor: TypeParser to use velox/.../prestosql/...TypeParser (prestodb#25877)
Summary: facebookincubator/velox#14208 moves velox/type/parser -> velox/functions/prestosql/types/parser. This is because this type parser was intended to be used for presto specific purposes, but was placed in a folder which seems too general. With this merged, now moving references to Velox's type parser to the new folder. Differential Revision: D80919225 ``` == NO RELEASE NOTE == ```
1 parent 27280fc commit 6d69b41

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

presto-native-execution/presto_cpp/main/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,10 @@ target_link_libraries(
7878
velox_hive_iceberg_splitreader
7979
velox_hive_partition_function
8080
velox_presto_serializer
81+
velox_presto_type_parser
8182
velox_s3fs
8283
velox_serialization
8384
velox_time
84-
velox_type_parser
8585
velox_type
8686
velox_type_fbhive
8787
velox_type_tz

presto-native-execution/presto_cpp/main/types/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
# limitations under the License.
1212

1313
add_library(presto_type_converter OBJECT TypeParser.cpp)
14-
target_link_libraries(presto_type_converter velox_type_parser)
14+
target_link_libraries(presto_type_converter velox_presto_type_parser)
1515

1616
add_library(presto_velox_expr_conversion OBJECT PrestoToVeloxExpr.cpp)
1717
target_link_libraries(presto_velox_expr_conversion velox_presto_types

presto-native-execution/presto_cpp/main/types/TypeParser.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#include <iostream>
1616

1717
#include "presto_cpp/main/types/TypeParser.h"
18-
#include "velox/type/parser/TypeParser.h"
18+
#include "velox/functions/prestosql/types/parser/TypeParser.h"
1919

2020
#include "presto_cpp/main/common/Configs.h"
2121

@@ -33,7 +33,7 @@ velox::TypePtr TypeParser::parse(const std::string& text) const {
3333
return it->second;
3434
}
3535

36-
auto result = velox::parseType(text);
36+
auto result = velox::functions::prestosql::parseType(text);
3737
cache_.insert({text, result});
3838
return result;
3939
}

presto-native-execution/presto_cpp/main/types/tests/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ target_link_libraries(
6767
velox_tpch_connector
6868
velox_hive_partition_function
6969
velox_presto_serializer
70+
velox_presto_type_parser
7071
velox_serialization
7172
velox_type
72-
velox_type_parser
7373
Boost::filesystem
7474
${RE2}
7575
${FOLLY_WITH_DEPENDENCIES}

0 commit comments

Comments
 (0)