-
Notifications
You must be signed in to change notification settings - Fork 41
Description
edm4hep::TrackerHitPlane
is heavily inspired by the lcio equivalent but the member description seems to somehow got lost.
For instance, the u
and v
members were described in lcio with "Direction of first/second measurement - given as (theta, phi). Defines spanning vector of measurement plane.".
Now we have "measurement direction vector, u lies in the x-y plane" and "measurement direction vector, v is along z", which is much less clear to me. Was there any intention to change the content w.r.t. the lcio version? If not I would propose to use the description from lcio. And we should probably add units ([rad]
for u
and v
and [mm]
for du
and dv
).
I am also guessing that the position
member should be in global coordinates, that could maybe be added as well.
Finally, can someone comment on the intended usage (or how it is used in ILCSoft)? I understood from a discussion at an edm4hep meeting that it was enabling the creation of 'measurements' for tracking without the need to access the geometry. But for instance, some tracking packages require planarMeasurement
in local coordinate of the sensor plane, this can currently not be constructed without accessing the geometry as far as I can tell.
Thanks a lot for your input!