fix: resolve remaining clippy lints for Rust 1.94 CI

- .filter(..).next_back() → .rfind(..) in compression_ops
- Remove needless borrows in file_associations_ops and system_ops
- Vec::new()+push → vec![] macro
- if let Ok(_) → .is_ok()
- Add .orchestrate/ to .gitignore

Author: kimlimjustin

.gitignore

@@ -40,4 +40,4 @@ e2e/screenshots/
 *.bak
 *.swp
 
-CLAUDE.md
+CLAUDE.md.orchestrate/

apps/src-tauri/src/operations/compression_ops.rs

@@ -1116,8 +1116,7 @@ async fn get_zip_info(archive_path: &Path) -> Result<ArchiveInfo, String> {
         let entry_name = file
             .name()
             .split('/')
-            .filter(|s| !s.is_empty())
-            .next_back()
+            .rfind(|s| !s.is_empty())
             .unwrap_or("")
             .to_string();
         files.push(ArchiveEntry {
@@ -1242,8 +1241,7 @@ fn get_tar_info_from_reader<R: Read>(
 
         let entry_name = path
             .split('/')
-            .filter(|s| !s.is_empty())
-            .next_back()
+            .rfind(|s| !s.is_empty())
             .unwrap_or("")
             .to_string();
         files.push(ArchiveEntry {
@@ -1691,8 +1689,7 @@ async fn get_7z_info(archive_path: &Path) -> Result<ArchiveInfo, String> {
 
                 let entry_name = name_str
                     .split('/')
-                    .filter(|s| !s.is_empty())
-                    .next_back()
+                    .rfind(|s| !s.is_empty())
                     .unwrap_or("")
                     .to_string();
 
@@ -1958,8 +1955,7 @@ async fn get_rar_info(archive_path: &Path) -> Result<ArchiveInfo, String> {
                 let entry_name = full_path
                     .split('/')
                     .chain(full_path.split('\\'))
-                    .filter(|s| !s.is_empty())
-                    .next_back()
+                    .rfind(|s| !s.is_empty())
                     .unwrap_or("")
                     .to_string();
 

apps/src-tauri/src/operations/file_associations_ops.rs

@@ -64,7 +64,7 @@ pub async fn open_file_with_application(file_path: String, app_path: String) ->
 
     #[cfg(windows)]
     {
-        let output = Command::new(&app_path).arg(&file_path).spawn();
+        let output = Command::new(app_path).arg(file_path).spawn();
 
         match output {
             Ok(_) => Ok(()),
@@ -74,7 +74,7 @@ pub async fn open_file_with_application(file_path: String, app_path: String) ->
 
     #[cfg(all(unix, not(target_os = "macos")))]
     {
-        let output = Command::new(&app_path).arg(&file_path).spawn();
+        let output = Command::new(app_path).arg(file_path).spawn();
 
         match output {
             Ok(_) => Ok(()),

apps/src-tauri/src/operations/system_ops.rs

@@ -88,14 +88,13 @@ pub async fn list_drives() -> Result<Vec<DriveInfo>, String> {
 
     #[cfg(target_os = "linux")]
     {
-        let mut drives = Vec::new();
-        drives.push(DriveInfo {
+        let drives = vec![DriveInfo {
             letter: String::new(),
             label: "Root".to_string(),
             path: "/".to_string(),
             total_space: 0,
             free_space: 0,
-        });
+        }];
         Ok(drives)
     }
 }
@@ -462,7 +461,7 @@ pub async fn open_file(path: String) -> Result<(), String> {
     #[cfg(target_os = "linux")]
     {
         std::process::Command::new("xdg-open")
-            .arg(&path)
+            .arg(path)
             .spawn()
             .map_err(|e| format!("Failed to open file: {}", e))?;
     }
@@ -510,10 +509,11 @@ pub async fn open_in_terminal(path: String) -> Result<(), String> {
         let mut success = false;
 
         for terminal in &terminals {
-            if let Ok(_) = std::process::Command::new(terminal)
+            if std::process::Command::new(terminal)
                 .arg("--working-directory")
-                .arg(&dir_path)
+                .arg(dir_path)
                 .spawn()
+                .is_ok()
             {
                 success = true;
                 break;