Added support for powerJoinHas with MorphTo relationships (#162)

* Added support for powerJoinHas with MorphTo relationships

* Readme addition

Author: luisdalmolin

README.md

@@ -278,6 +278,8 @@ There's, though, a gotcha here. Your global scope **cannot** type-hint the `Eloq
 
 This packages implements the same functionality, but instead of using the `where exists` syntax, it uses **joins**. Below, you can see the methods this package implements and also the Laravel equivalent.
 
+Please note that although the methods are similar, you will not always get the same results when using joins, depending on the context of your query. You should be aware of the differences between querying the data with `where exists` vs `joins`.
+
 **Laravel Native Methods**
 
 ``` php

src/Mixins/JoinRelationship.php

@@ -461,7 +461,7 @@ public function orderByLeftPowerJoinsMax(): Closure
      */
     public function powerJoinHas(): Closure
     {
-        return function ($relation, $operator = '>=', $count = 1, $boolean = 'and', $callback = null): static {
+        return function ($relation, $operator = '>=', $count = 1, $boolean = 'and', $callback = null, string $morphable = null): static {
             if (is_null($this->getSelect())) {
                 $this->select(sprintf('%s.*', $this->getModel()->getTable()));
             }
@@ -479,9 +479,8 @@ public function powerJoinHas(): Closure
 
                 $relation = $this->getRelationWithoutConstraintsProxy($relation);
             }
-
-            $relation->performJoinForEloquentPowerJoins($this, 'leftPowerJoin', $callback);
-            $relation->performHavingForEloquentPowerJoins($this, $operator, $count);
+            $relation->performJoinForEloquentPowerJoins($this, 'leftPowerJoin', $callback, morphable: $morphable);
+            $relation->performHavingForEloquentPowerJoins($this, $operator, $count, morphable: $morphable);
             return $this;
         };
     }

src/Mixins/RelationshipsExtraMethods.php

@@ -386,10 +386,18 @@ protected function performJoinForEloquentPowerJoinsForHasManyThrough()
      */
     public function performHavingForEloquentPowerJoins()
     {
-        return function ($builder, $operator, $count) {
-            $builder
-                ->selectRaw(sprintf('count(%s) as %s_count', $this->query->getModel()->getQualifiedKeyName(), $this->query->getModel()->getTable()))
-                ->havingRaw(sprintf('count(%s) %s %d', $this->query->getModel()->getQualifiedKeyName(), $operator, $count));
+        return function ($builder, $operator, $count, string $morphable = null) {
+            if ($morphable) {
+                $modelInstance = new $morphable;
+
+                $builder
+                    ->selectRaw(sprintf('count(%s) as %s_count', $modelInstance->getQualifiedKeyName(), $modelInstance->getTable()))
+                    ->havingRaw(sprintf('count(%s) %s %d', $modelInstance->getQualifiedKeyName(), $operator, $count));
+            } else {
+                $builder
+                    ->selectRaw(sprintf('count(%s) as %s_count', $this->query->getModel()->getQualifiedKeyName(), $this->query->getModel()->getTable()))
+                    ->havingRaw(sprintf('count(%s) %s %d', $this->query->getModel()->getQualifiedKeyName(), $operator, $count));
+            }
         };
     }
 

tests/PowerJoinHasTest.php

@@ -2,10 +2,11 @@
 
 namespace Kirschbaum\PowerJoins\Tests;
 
-use Kirschbaum\PowerJoins\Tests\Models\Comment;
-use Kirschbaum\PowerJoins\Tests\Models\Group;
 use Kirschbaum\PowerJoins\Tests\Models\Post;
 use Kirschbaum\PowerJoins\Tests\Models\User;
+use Kirschbaum\PowerJoins\Tests\Models\Group;
+use Kirschbaum\PowerJoins\Tests\Models\Image;
+use Kirschbaum\PowerJoins\Tests\Models\Comment;
 
 class PowerJoinHasTest extends TestCase
 {
@@ -171,4 +172,29 @@ public function test_where_has_with_joins_on_belongs_to_many_relationship()
         );
         $this->assertCount(1, $powerJoinQuery->get());
     }
+
+    public function test_power_join_has_with_morph_to()
+    {
+        $post = factory(Post::class)->state('published')->create();
+        $postImage = factory(Image::class)->state('owner:post')->create(['imageable_id' => $post->id]);
+        $user = factory(Post::class)->create();
+        $userImage = factory(Image::class)->state('owner:user')->create(['imageable_id' => $user->id]);
+
+        $postImagesQueried = Image::query()
+            ->powerJoinHas('imageable', morphable: Post::class)
+            ->get();
+
+        $userImagesQueried = Image::query()
+            ->powerJoinHas('imageable', morphable: User::class)
+            ->get();
+
+        $this->assertCount(1, $postImagesQueried);
+        $this->assertCount(1, Image::powerJoinHas('imageable', morphable: Post::class, callback: fn ($query) => $query->where('posts.published', true))->get());
+        $this->assertCount(0, Image::powerJoinHas('imageable', morphable: Post::class, callback: fn ($query) => $query->where('posts.published', false))->get());
+        $this->assertCount(0, Image::powerJoinHas('imageable', count: 2, morphable: Post::class)->get());
+        $this->assertTrue($postImage->is($postImagesQueried->sole()));
+
+        $this->assertCount(1, $userImagesQueried);
+        $this->assertTrue($userImage->is($userImagesQueried->sole()));
+    }
 }