Parse options given to packages

with test file

Author: kiryph

autoload/vimtex/state/class.vim

@@ -240,16 +240,44 @@ endfunction
 
 " }}}1
 function! s:parse_packages(preamble) abort " {{{1
-  let l:usepackages = filter(copy(a:preamble),
-        \ 'v:val =~# ''\v%(usep|RequireP)ackage''')
-  let l:pat = g:vimtex#re#not_comment . g:vimtex#re#not_bslash
-      \ . '\v\\%(usep|RequireP)ackage\s*%(\[[^[\]]*\])?\s*\{\s*\zs%([^{}]+)\ze\s*\}'
-  call map(l:usepackages, {_, x -> split(matchstr(x, l:pat), '\s*,\s*')})
+  " Remove EOL comments and then join
+  let l:preamble_joined = join(map(copy(a:preamble),
+        \ {_, x -> split(x..' ', '%')[0]}), '')
 
+  let l:pat = g:vimtex#re#not_comment . g:vimtex#re#not_bslash
+      \ . '\v\\%(usep|RequireP)ackage\s*%(\[([^[\]]*)\])?\s*\{\s*\zs%([^{}]+\S)\ze\s*\}'
+  " Regex:
+  " - Match contains package name(s)
+  " - First submatch contains package options
   let l:parsed = {}
-  for l:packages in l:usepackages
-    for l:package in l:packages
-      let l:parsed[l:package] = {}
+  for l:el in matchstrlist([l:preamble_joined], pat, #{submatches:v:true})
+    let l:packages = map(split(l:el['text'], ','), {_, x -> trim(x)})
+    let l:options = {}
+    if l:el['submatches'][0] != ''
+      for l:el in map(split(l:el['submatches'][0], ','), {_, x -> trim(x)})
+        if l:el == ''
+          " Empty option
+          continue
+        elseif l:el =~ '='
+          " Key-value option
+          let [l:key, l:value] = map(split(l:el, '='), {_, x -> trim(x)} )
+
+          if l:value ==? 'true'
+            let l:options[l:key] = v:true
+          elseif l:value ==? 'false'
+            let l:options[l:key] = v:false
+          else
+            let l:options[l:key] = l:value
+          endif
+
+        else
+          " Key-only option
+          let l:options[l:el] = v:true
+        endif
+      endfor
+    endif
+    for l:pkg in l:packages
+      let l:parsed[l:pkg] = l:options
     endfor
   endfor
 

test/test-state/test_parse_package_options.tex

@@ -0,0 +1,34 @@
+\RequirePackage[debrief]{silence}
+\documentclass{article}
+
+\usepackage[main=german,english]{babel}
+
+\usepackage[acronyms]{glossaries}
+\usepackage[record,style=long]{glossaries-extra}
+
+\usepackage[% comment
+  backend=biber,
+  style=numeric-comp,
+  maxcitenames=99,
+  % doi=false, % commented option
+  url=false,
+  giveninits=true,
+]{biblatex}
+
+\usepackage[notes, useibid]{biblatex-chicago} % with space
+
+% Issue in VimTeX 2.16 from January 2025:
+% Following multi-line syntax of \usepackage is not detected.
+\usepackage{
+  amsmath,
+  tikz
+}
+
+% Invalid syntax but parsed anyway
+\usepackage[draft]{package1, package2} % packages with a shared option
+
+\begin{document}
+
+Hello, world!
+
+\end{document}

test/test-state/test_parse_package_options.vim

@@ -0,0 +1,33 @@
+set nocompatible
+set runtimepath^=../..
+filetype plugin on
+
+nnoremap q :qall!<cr>
+
+call vimtex#log#set_silent()
+
+silent edit test_parse_package_options.tex
+
+if empty($INMAKE) | finish | endif
+
+let s:packages = {
+      \ 'glossaries-extra': {'style': 'long', 'record': v:true},
+      \ 'biblatex': {
+      \    'backend': 'biber',
+      \    'url': v:false,
+      \    'giveninits': v:true,
+      \    'style': 'numeric-comp',
+      \    'maxcitenames': '99'
+      \ },
+      \ 'glossaries': {'acronyms': v:true},
+      \ 'tikz': {},
+      \ 'babel' : {'main': 'german', 'english': v:true},
+      \ 'silence': {'debrief': v:true},
+      \ 'package1': {'draft': v:true},
+      \ 'biblatex-chicago': {'notes': v:true, 'useibid': v:true},
+      \ 'amsmath': {},
+      \ 'package2': {'draft': v:true}
+      \ }
+call assert_equal(s:packages, b:vimtex.packages)
+
+call vimtex#test#finished()