Skip to content

Commit f3884d9

Browse files
committed
updated readme, removed github refs
1 parent 2088896 commit f3884d9

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@ A Jenkins Plugin that provides SCMSource (i.e. [Pipeline Multibranch](https://wi
77
- Supports Pipeline Multibranch
88
- Auto creation of repository push web hook
99
- Support SCMNavigator (Gogs Organization Scanning) functionality (i.e. org scanning per [GitHub Organization Folder](https://wiki.jenkins-ci.org/display/JENKINS/GitHub+Organization+Folder+Plugin))
10+
- Commit status via repo issue creation on build FAILURE and UNSTABLE - Gogs currently doesn't support commit statuses see https://github.com/gogits/gogs/issues/813
11+
- Partial support for Gogs Organization avatar - Gogs does not support dynamically sized avatar images
1012

1113
##Missing Features
1214

1315
- Does not support Gogs Pull Requests - see https://github.com/gogits/gogs/issues/2246
1416
- Does not support auto-creation of Organization web hooks - see https://github.com/gogits/go-gogs-client/issues/38
1517
- Update commit status - see https://github.com/gogits/gogs/issues/813
16-
- Does not support Gogs Organization avatar as it is only available in one size

src/main/java/com/cloudbees/jenkins/plugins/gogs/RepositoryUriResolver.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ public static String hostnameFromApiUri(String apiUri) {
4646
// ignore
4747
}
4848
}
49-
return "github.com";
49+
//apiUri can't be null
50+
throw new NullPointerException();
5051
}
5152
}

src/main/java/com/cloudbees/jenkins/plugins/gogs/notification/GogsBuildStatusNotification.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ private static void createBuildCommitStatus(Run<?,?> build, TaskListener listene
124124
}
125125

126126
/**
127-
* Returns the GitHub Repository associated to a Job.
127+
* Returns the SCMSourceOwner associated to a Job.
128128
*
129129
* @param job A {@link Job}
130130
* @return A {@link GogsApi} or null, either if a scan credentials was not provided, or a GitHubSCMSource was not defined.
@@ -158,7 +158,7 @@ private static GogsSCMSource getSCMSource(final SCMSourceOwner scmSourceOwner) {
158158

159159

160160
/**
161-
* With this listener one notifies to GitHub when the SCM checkout process has started.
161+
* With this listener one notifies to Gogs when the SCM checkout process has started.
162162
* Possible option: GHCommitState.PENDING
163163
*/
164164
@Extension public static class JobCheckOutListener extends SCMListener {

0 commit comments

Comments
 (0)