Skip to content

Services not using correct image for queue-proxy sidecar #2313

Description

@alanrichman

Describe the bug

The configuration for overriding the image used by the queue-proxy sidecar is not working in my environment.

I am following the documentation to control the images used for Knative serving: https://knative.dev/docs/install/operator/configuring-serving-cr/#download-images-individually-without-secrets

Here is a sanitized version of my KnativeServing resource manifest

apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  registry:
    imagePullSecrets:
    - name: my-secret
    override:
      3scale-kourier-gateway/kourier-gateway: registry.my-org.com/knative-serving-kourier-gateway:1.35.3
      activator: registry.my-org.com/knative-serving-activator:1.22.0
      autoscaler: registry.my-org.com/knative-serving-autoscaler:1.22.0
      autoscaler-hpa: registry.my-org.com/knative-serving-autoscaler-hpa:1.22.0
      controller: registry.my-org.com/knative-serving-controller:1.22.0
      net-kourier-controller/controller: registry.my-org.com/knative-serving-kourier-controller:1.22.0
      queue-proxy: registry.my-org.com/knative-serving-queue:1.22.0
      webhook: registry.my-org.com/knative-serving-webhook:1.22.0
  version: 1.22.0

The services continue to use the default image for the queue-proxy container. My cluster's config-deployment Config Map has the default image specified in it explicitly:

apiVersion: v1
kind: ConfigMap
metadata:
  name: config-deployment
  namespace: knative-serving
data:
  queue-sidecar-image: gcr.io/knative-releases/knative.dev/serving/cmd/queue@sha256:371c23206b7bd924474b07e51435198579133eb98fba27a5cb3db9e6ba63b06b

Expected behavior

My expectation is that this would configure the Services to use my specified image for the queue-proxy container.

To Reproduce

  1. Install Knative Operator v1.22.1
  2. Create a KnativeServing resource with the queue-proxy image overridden
  3. Observe Service deployments not using the specified image for the queue-proxy container

Knative release version

Knative Operator 1.22.1 with Knative Serving 1.22.0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions