Merge pull request #471 from kbond/ci-fix2

CS & SCA fixes

Author: kbond

src/Client/Provider/PassageClient.php

@@ -39,7 +39,7 @@ public function logout(): RedirectResponse
     {
         $provider = $this->getOAuth2Provider();
 
-        if (!($provider instanceof Passage)) {
+        if (!$provider instanceof Passage) {
             throw new \RuntimeException('Invalid provider "'.$provider::class.'", expected provider "'.Passage::class.'"');
         }
 

src/DependencyInjection/Configuration.php

@@ -44,7 +44,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                 ->end()
             ->end()
             ->validate()
-                ->ifTrue(fn ($v) => isset($v['http_client_options'], $v['http_client']) && !empty($v['http_client_options']))
+                ->ifTrue(static fn ($v) => isset($v['http_client_options'], $v['http_client']) && !empty($v['http_client_options']))
                 ->thenInvalid('You cannot use both "http_client_options" and "http_client" at the same time under "knpu_oauth2_client".')
             ->end()
         ;

src/DependencyInjection/Providers/AzureProviderConfigurator.php

@@ -88,14 +88,14 @@ public function buildConfiguration(NodeBuilder $node)
             ->end();
 
         // Validate that either client_secret or client_certificate_private_key is set:
-        $node
+        $node // @phpstan-ignore-line
             ->end()
               ->validate()
-                ->ifTrue(fn ($v) => empty($v['client_secret']) && empty($v['client_certificate_private_key']))
+                ->ifTrue(static fn ($v) => empty($v['client_secret']) && empty($v['client_certificate_private_key']))
                 ->thenInvalid('You have to define either client_secret or client_certificate_private_key')
               ->end()
                 ->validate()
-                ->ifTrue(fn ($v) => !empty($v['client_certificate_private_key']) && empty($v['client_certificate_thumbprint']))
+                ->ifTrue(static fn ($v) => !empty($v['client_certificate_private_key']) && empty($v['client_certificate_thumbprint']))
               ->thenInvalid('You have to define the client_certificate_thumbprint when using a certificate')
             ->end();
     }