fix: address CodeRabbit review comments

- husky pre-commit: respect existing NVM_DIR with parameter expansion fallback
- base.ts: gate error emission on emitResponseChunks to avoid surfacing
  internal "thinking" operation errors to users

Signed-off-by: ibolton336 <ibolton@redhat.com>

Author: ibolton336

.husky/pre-commit

@@ -2,5 +2,7 @@
 #
 # Auto-fix any list errors in staged files
 #
-npx lint-staged
+export NVM_DIR="${NVM_DIR:-$HOME/.nvm}"
+[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
 
+npx lint-staged

agentic/src/nodes/base.ts

@@ -156,11 +156,13 @@ export abstract class BaseNode extends KaiWorkflowEventEmitter {
           errorStack: err instanceof Error ? err.stack : undefined,
         },
       );
-      this.emitWorkflowMessage({
-        id: messageId,
-        type: KaiWorkflowMessageType.Error,
-        data: `Failed to get llm response - ${String(err)}`,
-      });
+      if (emitResponseChunks) {
+        this.emitWorkflowMessage({
+          id: messageId,
+          type: KaiWorkflowMessageType.Error,
+          data: `Failed to get llm response - ${String(err)}`,
+        });
+      }
     } finally {
       if (timeoutId !== undefined) {
         clearTimeout(timeoutId);

tests/e2e/pages/vscode-web.page.ts

@@ -199,7 +199,11 @@ export abstract class VSCode {
       await runAnalysisBtnLocator.click();
 
       console.log('Waiting for analysis progress indicator...');
-      await expect(analysisView.getByText('Analysis Progress').first()).toBeVisible();
+      await expect(
+        analysisView.getByRole('button', {
+          name: 'Analyzing...',
+        })
+      ).toBeDisabled();
       console.log('Analysis started successfully');
     } catch (error) {
       console.log('Error running analysis:', error);
@@ -699,7 +703,8 @@ export abstract class VSCode {
   public async executeTerminalCommand(
     command: string,
     expectedOutput?: string | RegExp,
-    outputShouldBeVisible: boolean = true
+    outputShouldBeVisible: boolean = true,
+    timeout: number = 30_000
   ): Promise<void> {
     if (!this.repoDir || !this.branch) {
       throw new Error('executeTerminalCommand requires repoDir and branch to be set');
@@ -720,7 +725,7 @@ export abstract class VSCode {
         path: pathlib.join(SCREENSHOTS_FOLDER, `last-command.png`),
       });
       if (outputShouldBeVisible) {
-        await expect(this.window.getByText(expectedOutput).first()).toBeVisible();
+        await expect(this.window.getByText(expectedOutput).first()).toBeVisible({ timeout });
       } else {
         try {
           await expect(this.window.getByText(expectedOutput).first()).not.toBeVisible();

tests/e2e/pages/vscode.page.ts

@@ -27,6 +27,7 @@ test.describe.serial('Plugin Settings - Analyze on Save', { tag: ['@tier1'] }, (
   const profileName = `plugins-settings-${generateRandomString()}`;
 
   test.beforeAll(async ({ testRepoData }) => {
+    test.setTimeout(600_000);
     if (getDefaultProviderConfig() === LLEMULATOR_PROVIDER) {
       await loadLlemulatorResponses({
         reset: true,
@@ -111,7 +112,7 @@ test.describe.serial('Plugin Settings - Analyze on Save', { tag: ['@tier1'] }, (
   });
 
   test.beforeEach(async function () {
-    test.setTimeout(300000);
+    test.setTimeout(600_000);
     const testName = test.info().title.replace(/[_"'\s]/g, '');
     console.log(`Starting ${testName} at ${new Date()}`);
 
@@ -198,14 +199,17 @@ test.describe.serial('Plugin Settings - Analyze on Save', { tag: ['@tier1'] }, (
     await tabManager.saveTabFile(FILES_NAMES[1]);
     const rejectChangesBtn = vscodeApp.getWindow().getByText('Reject All Changes');
     // the diff should still be there when auto accept on save is disabled
+    await vscodeApp.waitDefault();
     await rejectChangesBtn.click();
+    await vscodeApp.assertNotification('Changes rejected and document saved', { timeout: 30_000 });
     await tabManager.saveTabFile(FILES_NAMES[1]);
     await tabManager.closeTabByName(FILES_NAMES[1]);
     await vscodeApp.executeTerminalCommand('git status', 'Changes not staged for commit', false);
     await vscodeApp.executeQuickCommand('View: Close All Editors');
   });
 
   test('Exclude diagnostic sources in agent mode', async ({ testRepoData }) => {
+    test.skip(!!process.env.WEB_ENV, 'Skipping test that requires a VS Code restart in web mode.');
     test.setTimeout(600000);
     const repoInfo = testRepoData['coolstore'];
 

tests/e2e/tests/base/plugin-settings.test.ts

@@ -70,6 +70,12 @@ test.describe.serial(
       ).toBeVisible({ timeout: 30000 });
     });
 
+    test.beforeEach(async function () {
+      test.setTimeout(300_000);
+      const testName = test.info().title.replace(/[_"'\s]/g, '');
+      console.log(`Starting ${testName} at ${new Date()}`);
+    });
+
     test('Hub LLM proxy configuration and notifications', async () => {
       console.log('Configuring Hub connection with profile sync enabled...');
       const authEnabled = !!(process.env.TEST_HUB_USERNAME && process.env.TEST_HUB_PASSWORD);

tests/e2e/tests/ccm/llm-proxy.test.ts

@@ -98,6 +98,7 @@ export const extensionDependencies: Record<string, string[]> = {
 // Other Configuration
 // ============================================================================
 export const extensionShortName = process.env.TEST_CATEGORY || 'Konveyor';
+export const extensionLongName = process.env.TEST_CATEGORY_LONG || 'Konveyor';
 
 // Function to get the analysis view title based on extension short name
 export function getAnalysisViewTitle(): string {

tests/e2e/utilities/utils.ts

@@ -213,9 +213,7 @@ export async function handleFileResponse(
           try {
             const diskBytes = await vscode.workspace.fs.readFile(uri);
             finalContent = new TextDecoder().decode(diskBytes);
-            logger.info(
-              `Using on-disk content for solution server (captures in-place edits): ${path}`,
-            );
+            logger.info(`Using on-disk content for solution server (captures in-place edits): ${path}`);
           } catch (readError) {
             logger.warn(`Could not read disk content, using original content: ${path}`, readError);
           }