deprecations

Author: kornrunner

.github/workflows/tests.yml

@@ -26,7 +26,7 @@ jobs:
       - run: php -m
       - run: composer -V
       - run: composer install --no-progress
-      - run: php vendor/bin/phpunit
+      - run: php vendor/bin/phpunit --no-coverage
 
   windows:
     name: Test on Windows
@@ -50,7 +50,7 @@ jobs:
       - run: php -m
       - run: composer -V
       - run: composer install --no-progress
-      - run: php vendor/bin/phpunit
+      - run: php vendor/bin/phpunit --no-coverage
 
   code_coverage:
     name: Code Coverage

test/unit/HexPrivateKeySerializerTest.php

@@ -5,6 +5,7 @@
 use kornrunner\Serializer\HexPrivateKeySerializer;
 use Mdanter\Ecc\Curves\CurveFactory;
 use Mdanter\Ecc\Curves\SecgCurve;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class HexPrivateKeySerializerTest extends TestCase
 {
@@ -18,9 +19,7 @@ public function setUp(): void
         $this->serializer = new HexPrivateKeySerializer($generator);
     }
 
-    /**
-     * @dataProvider parse
-     */
+    #[DataProvider('parse')]
     public function testParse(string $privateKey) {
         $key = $this->serializer->parse($privateKey);
         $this->assertEquals(gmp_init($privateKey, 16), $key->getSecret());
@@ -33,9 +32,7 @@ public static function parse(): array {
         ];
     }
 
-    /**
-     * @dataProvider serialize
-     */
+    #[DataProvider('serialize')]
     public function testSerialize(string $privateKey, string $expect) {
         $key = $this->serializer->serialize($this->serializer->parse($privateKey));
         $this->assertEquals($expect, $key);

test/unit/HexSignatureSerializerTest.php

@@ -3,13 +3,12 @@
 namespace kornrunner;
 
 use InvalidArgumentException;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class HexSignatureSerializerTest extends TestCase
 {
 
-    /**
-     * @dataProvider data
-     */
+    #[DataProvider('data')]
     public function testParse(string $input, string $expect) {
         $sig = $this->sigSerializer->parse($input);
         $this->assertEquals($expect, gmp_strval($sig->getR(), 16) . gmp_strval($sig->getS(), 16));
@@ -20,9 +19,7 @@ public function testParseException() {
         $this->sigSerializer->parse($this->signed . random_bytes(3));
     }
 
-    /**
-     * @dataProvider data
-     */
+    #[DataProvider('data')]
     public function testSerialize(string $input, string $expect) {
         $parsed = $this->sigSerializer->parse($input);
         $signed = $this->sigSerializer->serialize($parsed);

test/unit/Secp256k1Test.php

@@ -3,6 +3,7 @@
 namespace kornrunner;
 
 use kornrunner\Secp256k1;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 class Secp256k1Test extends TestCase
 {
@@ -13,9 +14,7 @@ public function setUp(): void {
         $this->secp256k1 = new Secp256k1();
     }
 
-    /**
-     * @dataProvider sign
-     */
+    #[DataProvider('sign')]
     public function testSign(string $message, string $key, array $expected) {
         $signature = $this->secp256k1->sign($message, $key);
 
@@ -53,9 +52,7 @@ public static function sign(): array {
         ];
     }
 
-    /**
-     * @dataProvider verify
-     */
+    #[DataProvider('verify')]
     public function testVerify(string $message, string $key, string $publicKey) {
         $signature = $this->secp256k1->sign($message, $key);
         $this->assertTrue($this->secp256k1->verify($message, $signature, $publicKey));
@@ -68,9 +65,7 @@ public static function verify (): array {
         ];
     }
 
-    /**
-     * @dataProvider verifyWithStringSignature
-     */
+    #[DataProvider('verifyWithStringSignature')]
     public function testVerifyWithStringSignature(string $message, string $signatureString, string $publicKey) {
         $this->assertTrue($this->secp256k1->verify($message, $signatureString, $publicKey));
     }