-
Notifications
You must be signed in to change notification settings - Fork 51
Open
Labels
help wantedExtra attention is neededExtra attention is neededkind/enhancementkind - new features or changeskind - new features or changespriority/needs-triagepriority - needs to be triagedpriority - needs to be triaged
Description
Checks
- I have searched the existing issues.
- My request is related to one of the components in the
kubeflow/dashboardrepository.
Motivation
Currently the centraldashboard is being served via npm start as part of the Dockerfile:
dashboard/components/centraldashboard/Dockerfile
Lines 19 to 31 in 41dc738
| # Step 2: Packages assets for serving | |
| FROM node:16.20.2-alpine AS serve | |
| RUN apk add --no-cache tini | |
| USER node | |
| ENV NODE_ENV=production | |
| WORKDIR /usr/src/app | |
| COPY --from=build --chown=node:node /centraldashboard . | |
| EXPOSE 8082 | |
| ENTRYPOINT ["/sbin/tini", "--" , "npm", "start"] |
Optimally this dependency could be eliminated in the final part of the image in order to have less attack surface, especially given how old some parts of the components are.
Implementation
The Dockerfile for kubeflow/notebooks (v2) could be a good inspiration for the implementation:
https://github.com/kubeflow/notebooks/blob/notebooks-v2/workspaces/frontend/Dockerfile
Are you willing & able to help?
- I am able to submit a PR!
- I can help test the feature!
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is neededkind/enhancementkind - new features or changeskind - new features or changespriority/needs-triagepriority - needs to be triagedpriority - needs to be triaged