Skip to content

Commit afca8b5

Browse files
Merge pull request #737 from dandawg/improved-template
fix: improved membership request template
2 parents e071341 + 2a8731f commit afca8b5

1 file changed

Lines changed: 24 additions & 20 deletions

File tree

.github/ISSUE_TEMPLATE/join_org.md

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,29 @@ about: Request to join or modify Kubeflow GitHub membership
66

77
# Membership Request
88

9-
Please read the [guidelines](https://www.kubeflow.org/docs/about/contributing/#joining-the-community) for joining the Kubeflow GitHub org before opening an issue
10-
11-
**Please provide links to PRs or other contributions (2-3):**
12-
13-
**Please list 2 existing members who are sponsoring your membership:**
14-
15-
## Please test your PR
16-
17-
Run
18-
19-
```bash
20-
cd github_orgs
21-
pytest test_org_yaml.py
22-
```
23-
24-
Include the output in the PR
9+
## Instructions
10+
Please read the [guidelines](https://www.kubeflow.org/docs/about/contributing/#joining-the-community) for joining the Kubeflow GitHub org before opening an issue.
11+
12+
### Provide links to your PRs or other contributions (2-3):
13+
14+
### List 2 existing members who are sponsoring your membership:
15+
16+
### Create a new membership pull request (PR):
17+
- Fork the [kubeflow/internals-acls](https://github.com/kubeflow/internal-acls/) repo and clone it locally.
18+
- Modify [github-orgs/kubeflow/org.yaml](github-orgs/kubeflow/org.yaml) to include your GitHub username in the appropriate places.
19+
- In the `org.kubeflow.members` list
20+
- If you work for a company that is recognized by the Kubeflow project, then in your company team list (check `org.kubeflow.teams`)
21+
- Test your code changes with:
22+
```bash
23+
cd github_orgs
24+
pytest test_org_yaml.py
25+
```
26+
Confirm that the test run passed, and make sure to copy the test output so you can include it in your PR description (on GitHub).
27+
- Push your changes to your `kubeflow/internals-acls` repository fork.
28+
- Open a PR from the [kubeflow/internals-acls](https://github.com/kubeflow/internal-acls/) repo.
29+
- Your PR will be reviewed by someone from the Kubeflow team. Work with your reviewers to address any outstanding issues.
2530

2631
## Additional Instructions
27-
28-
After your PR is merged please wait at least 1 hour for changes to propogate.
29-
30-
If after an hour you haven't recieved an invite to join the GitHub org please open an issue.
32+
- After your PR is merged please wait at least 1 hour for changes to propagate.
33+
- You will receive an email invite (to your GitHub associated email address) to join Kubeflow on GitHub. Follow the instructions on the email to accept your invitation.
34+
- If after an hour you haven't received an invite to join the GitHub org (or your invite has expired) please open an issue with an [owner](../../OWNERS) tagged to request follow-up.

0 commit comments

Comments
 (0)