feat(jupyter): use generateName for PVCs created by Notebook form

Changes the Jupyter Notebook form to use Kubernetes generateName instead
of name when creating new PVCs. This prevents naming conflicts when
notebooks are recreated or when PVCs from deleted notebooks still exist.

Changes:
- createNewPvcFormGroup(): use generateName instead of name
- Default volume names now end with '-' (required for generateName)
- Workspace volume: {notebook-name}-workspace-
- Data volumes: {notebook-name}-datavol-{n}-

Signed-off-by: Feiyu Zhang <feiyuzhang@nianticlabs.com>

Author: feiyuzhang

components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-new/form-data-volumes/form-data-volumes.component.ts

@@ -39,7 +39,7 @@ export class FormDataVolumesComponent implements OnInit {
   addNewVolume() {
     const volId = this.volsArray.length + 1;
     const volGroup = createNewPvcVolumeFormGroup(
-      `{notebook-name}-datavol-${volId}`,
+      `{notebook-name}-datavol-${volId}-`,
     );
 
     this.volsArray.push(volGroup);

components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-new/form-workspace-volume/form-workspace-volume.component.ts

@@ -50,7 +50,7 @@ export class FormWorkspaceVolumeComponent implements OnInit, OnDestroy {
   }
 
   addNewVolume() {
-    this.volGroup.addControl('newPvc', createNewPvcFormGroup());
+    this.volGroup.addControl('newPvc', createNewPvcFormGroup('{notebook-name}-workspace-'));
     this.volGroup.get('mount').setValue('/home/jovyan');
     this.volGroup.enable();
     this.volGroup.get('newPvc.spec.storageClassName').disable();

components/crud-web-apps/jupyter/frontend/src/app/shared/utils/volumes/forms.ts

@@ -70,11 +70,11 @@ export function createExistingSourceFormGroup(): FormGroup {
 
 // for volume.newPvc
 export function createNewPvcFormGroup(
-  name = '{notebook-name}-volume',
+  name = '{notebook-name}-volume-',
 ): FormGroup {
   return new FormGroup({
     metadata: new FormGroup({
-      name: new FormControl(name, Validators.required),
+      generateName: new FormControl(name, Validators.required),
     }),
     spec: new FormGroup({
       accessModes: new FormControl(['ReadWriteOnce']),