chore: upgrade to go 1.24 for notebook-controller (#748)

* feat: Upgrade Go to 1.24 - notebook-controller component. #721

Signed-off-by: Abdallah Samara (EXT-Nokia) <abdallah.samara.ext@nokia.com>

* Update nb_controller_integration_test.yaml

Signed-off-by: abdallahsamabd <42250800+abdallahsamabd@users.noreply.github.com>

* Update nb_controller_multi_arch_test.yaml

Signed-off-by: abdallahsamabd <42250800+abdallahsamabd@users.noreply.github.com>

* Update tb_controller_docker_publish.yaml

Signed-off-by: abdallahsamabd <42250800+abdallahsamabd@users.noreply.github.com>

* Update workflow triggers for unit tests

Signed-off-by: abdallahsamabd <42250800+abdallahsamabd@users.noreply.github.com>

* Update Dockerfile

Signed-off-by: abdallahsamabd <42250800+abdallahsamabd@users.noreply.github.com>

* Update nb_controller_unit_test.yaml

Signed-off-by: abdallahsamabd <42250800+abdallahsamabd@users.noreply.github.com>

* mathew: run go mod tidy + make to generate

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

---------

Signed-off-by: Abdallah Samara (EXT-Nokia) <abdallah.samara.ext@nokia.com>
Signed-off-by: abdallahsamabd <42250800+abdallahsamabd@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Co-authored-by: Abdallah Samara (EXT-Nokia) <abdallah.samara.ext@nokia.com>
Co-authored-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>

Author: 3 people

.github/workflows/nb_controller_unit_test.yaml

@@ -19,7 +19,7 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: "1.17"
+        go-version-file: 'components/notebook-controller/go.mod'
         check-latest: true
 
     - name: Run unit tests

components/notebook-controller/Dockerfile

@@ -4,7 +4,7 @@
 #
 # ${PATH_TO_KUBEFLOW/KUBEFLOW repo}/components
 #
-ARG GOLANG_VERSION=1.17
+ARG GOLANG_VERSION=1.24
 FROM golang:${GOLANG_VERSION} as builder
 
 WORKDIR /workspace
@@ -16,10 +16,18 @@ COPY notebook-controller /workspace/notebook-controller
 # and so that source changes don't invalidate our downloaded layer
 RUN cd /workspace/notebook-controller && go mod download
 
+# Force download and extract all HashiCorp modules so they exist under /go/pkg/mod
+RUN set -e; cd /workspace/notebook-controller; \
+  for m in $(go list -m all | awk '/^github.com\/hashicorp\// {print $1 "@" $2}'); do \
+    go mod download "$m"; \
+    pkg="${m%@*}"; \
+    go list "$pkg/..." >/dev/null 2>&1 || true; \
+  done
+
 WORKDIR /workspace/notebook-controller
 
 # Build
-RUN CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -a -mod=mod -o manager main.go
+RUN CGO_ENABLED=0 GOOS=linux go build -a -o manager main.go
 
 # Use distroless as minimal base image to package the manager binary
 # Refer to https://github.com/GoogleContainerTools/distroless for more details

components/notebook-controller/Makefile

@@ -136,7 +136,7 @@ undeploy: ## Undeploy controller from the K8s cluster specified in ~/.kube/confi
 CONTROLLER_GEN = $(shell pwd)/bin/controller-gen
 .PHONY: controller-gen
 controller-gen: ## Download controller-gen locally if necessary.
-	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.8.0)
+	$(call go-get-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0)
 
 KUSTOMIZE = $(shell pwd)/bin/kustomize
 .PHONY: kustomize

components/notebook-controller/README.md

@@ -80,7 +80,7 @@ notebook-controller-deployment-564d76877-mqsm8   1/1     Running   0          16
 ```
 
 ### Build and Run the Controller locally
-In order to build the controller you will need to use Go 1.17 and up in order to have Go Modules support. You will also need to have a k8s cluster.
+In order to build the controller you will need to use Go 1.24 and up in order to have Go Modules support. You will also need to have a k8s cluster.
 
 1. Install the CRDs into the cluster:
 
@@ -135,7 +135,7 @@ make uninstall
 
 To develop on `notebook-controller`, your environment must have the following:
 
-- [go](https://golang.org/dl/) version v1.17+.
+- [go](https://golang.org/dl/) version v1.24+.
 - [docker](https://docs.docker.com/install/) version 20.10+.
 - [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/) version 1.22.0+.
 - [kustomize](https://sigs.k8s.io/kustomize/docs/INSTALL.md) version 3.8.7+.