Skip to content

Commit 1f1de82

Browse files
authored
Merge pull request #23 from mkimuram/issue/22
Rename hello.k8s.io to hello.example.com
2 parents abaf9b8 + e03a80e commit 1f1de82

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

example/hello-populator/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Create a CR:
2020

2121
```
2222
kubectl create -f - << EOF
23-
apiVersion: hello.k8s.io/v1alpha1
23+
apiVersion: hello.example.com/v1alpha1
2424
kind: Hello
2525
metadata:
2626
name: hello1
@@ -44,8 +44,8 @@ spec:
4444
resources:
4545
requests:
4646
storage: 10Mi
47-
dataSource:
48-
apiGroup: hello.k8s.io
47+
dataSourceRef:
48+
apiGroup: hello.example.com
4949
kind: Hello
5050
name: hello1
5151
EOF

example/hello-populator/crd.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
apiVersion: apiextensions.k8s.io/v1
22
kind: CustomResourceDefinition
33
metadata:
4-
name: hellos.hello.k8s.io
5-
annotations:
6-
api-approved.kubernetes.io: unapproved
4+
name: hellos.hello.example.com
75
spec:
8-
group: hello.k8s.io
6+
group: hello.example.com
97
names:
108
kind: Hello
119
listKind: HelloList

example/hello-populator/deploy.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ rules:
2727
resources: [storageclasses]
2828
verbs: [get, list, watch]
2929

30-
- apiGroups: [hello.k8s.io]
30+
- apiGroups: [hello.example.com]
3131
resources: [hellos]
3232
verbs: [get, list, watch]
3333
---
@@ -61,11 +61,11 @@ spec:
6161
serviceAccount: hello-account
6262
containers:
6363
- name: hello
64-
image: k8s.gcr.io/sig-storage/hello-populator:v0.1.0
64+
image: k8s.gcr.io/sig-storage/hello-populator:v1.0.0
6565
imagePullPolicy: IfNotPresent
6666
args:
6767
- --mode=controller
68-
- --image-name=k8s.gcr.io/sig-storage/hello-populator:v0.1.0
68+
- --image-name=k8s.gcr.io/sig-storage/hello-populator:v1.0.0
6969
- --http-endpoint=:8080
7070
ports:
7171
- containerPort: 8080
@@ -77,5 +77,5 @@ apiVersion: populator.storage.k8s.io/v1beta1
7777
metadata:
7878
name: hello-populator
7979
sourceKind:
80-
group: hello.k8s.io
80+
group: hello.example.com
8181
kind: Hello

example/hello-populator/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import (
3232
)
3333

3434
const (
35-
prefix = "hello.k8s.io"
35+
prefix = "hello.example.com"
3636
mountPath = "/mnt"
3737
devicePath = "/dev/block"
3838
)
@@ -77,7 +77,7 @@ func main() {
7777
switch mode {
7878
case "controller":
7979
const (
80-
groupName = "hello.k8s.io"
80+
groupName = "hello.example.com"
8181
apiVersion = "v1alpha1"
8282
kind = "Hello"
8383
resource = "hellos"

0 commit comments

Comments
 (0)