[feat: aga] add basic framework for AGA controller

Author: shraddhabang

controllers/aga/globalaccelerator_controller.go

@@ -0,0 +1,189 @@
+/*
+
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package controllers
+
+import (
+	"context"
+	"fmt"
+	"github.com/go-logr/logr"
+	corev1 "k8s.io/api/core/v1"
+	"k8s.io/apimachinery/pkg/types"
+	"k8s.io/client-go/tools/record"
+	"sigs.k8s.io/aws-load-balancer-controller/pkg/shared_constants"
+	ctrl "sigs.k8s.io/controller-runtime"
+	"sigs.k8s.io/controller-runtime/pkg/client"
+	"sigs.k8s.io/controller-runtime/pkg/controller"
+	"sigs.k8s.io/controller-runtime/pkg/reconcile"
+
+	agaapi "sigs.k8s.io/aws-load-balancer-controller/apis/aga/v1beta1"
+	"sigs.k8s.io/aws-load-balancer-controller/pkg/config"
+	ctrlerrors "sigs.k8s.io/aws-load-balancer-controller/pkg/error"
+	"sigs.k8s.io/aws-load-balancer-controller/pkg/k8s"
+	lbcmetrics "sigs.k8s.io/aws-load-balancer-controller/pkg/metrics/lbc"
+	metricsutil "sigs.k8s.io/aws-load-balancer-controller/pkg/metrics/util"
+	"sigs.k8s.io/aws-load-balancer-controller/pkg/runtime"
+)
+
+const (
+	controllerName = "globalAccelerator"
+
+	// Metric stage constants
+	MetricStageFetchGlobalAccelerator     = "fetch_globalAccelerator"
+	MetricStageAddFinalizers              = "add_finalizers"
+	MetricStageReconcileGlobalAccelerator = "reconcile_globalaccelerator"
+
+	// Metric error constants
+	MetricErrorAddFinalizers              = "add_finalizers_error"
+	MetricErrorReconcileGlobalAccelerator = "reconcile_globalaccelerator_error"
+)
+
+// NewGlobalAcceleratorReconciler constructs new globalAcceleratorReconciler
+func NewGlobalAcceleratorReconciler(k8sClient client.Client, eventRecorder record.EventRecorder, finalizerManager k8s.FinalizerManager,
+	config config.ControllerConfig, logger logr.Logger, metricsCollector lbcmetrics.MetricCollector, reconcileCounters *metricsutil.ReconcileCounters) *globalAcceleratorReconciler {
+
+	return &globalAcceleratorReconciler{
+		k8sClient:        k8sClient,
+		eventRecorder:    eventRecorder,
+		finalizerManager: finalizerManager,
+		logger:           logger,
+		metricsCollector: metricsCollector,
+		reconcileTracker: reconcileCounters.IncrementAGA,
+
+		maxConcurrentReconciles: config.GlobalAcceleratorMaxConcurrentReconciles,
+	}
+}
+
+// globalAcceleratorReconciler reconciles a GlobalAccelerator object
+type globalAcceleratorReconciler struct {
+	k8sClient        client.Client
+	eventRecorder    record.EventRecorder
+	finalizerManager k8s.FinalizerManager
+	logger           logr.Logger
+	metricsCollector lbcmetrics.MetricCollector
+	reconcileTracker func(namespaceName types.NamespacedName)
+
+	maxConcurrentReconciles int
+}
+
+// +kubebuilder:rbac:groups=aga.k8s.aws,resources=globalaccelerators,verbs=get;list;watch;patch
+// +kubebuilder:rbac:groups=aga.k8s.aws,resources=globalaccelerators/status,verbs=update;patch
+// +kubebuilder:rbac:groups=aga.k8s.aws,resources=globalaccelerators/finalizers,verbs=update;patch
+func (r *globalAcceleratorReconciler) Reconcile(ctx context.Context, req reconcile.Request) (ctrl.Result, error) {
+	r.reconcileTracker(req.NamespacedName)
+	r.logger.V(1).Info("Reconcile request", "name", req.Name)
+	err := r.reconcile(ctx, req)
+	return runtime.HandleReconcileError(err, r.logger)
+}
+
+func (r *globalAcceleratorReconciler) reconcile(ctx context.Context, req reconcile.Request) error {
+	ga := &agaapi.GlobalAccelerator{}
+	var err error
+	fetchGlobalAcceleratorFn := func() {
+		err = r.k8sClient.Get(ctx, req.NamespacedName, ga)
+	}
+	r.metricsCollector.ObserveControllerReconcileLatency(controllerName, MetricStageFetchGlobalAccelerator, fetchGlobalAcceleratorFn)
+	if err != nil {
+		return client.IgnoreNotFound(err)
+	}
+
+	if ga.DeletionTimestamp != nil && !ga.DeletionTimestamp.IsZero() {
+		return r.cleanupGlobalAccelerator(ctx, ga)
+	}
+	return r.reconcileGlobalAccelerator(ctx, ga)
+}
+
+func (r *globalAcceleratorReconciler) reconcileGlobalAccelerator(ctx context.Context, ga *agaapi.GlobalAccelerator) error {
+	var err error
+	finalizerFn := func() {
+		if !k8s.HasFinalizer(ga, shared_constants.GlobalAcceleratorFinalizer) {
+			err = r.finalizerManager.AddFinalizers(ctx, ga, shared_constants.GlobalAcceleratorFinalizer)
+		}
+	}
+	r.metricsCollector.ObserveControllerReconcileLatency(controllerName, MetricStageAddFinalizers, finalizerFn)
+	if err != nil {
+		r.eventRecorder.Event(ga, corev1.EventTypeWarning, k8s.GlobalAcceleratorEventReasonFailedAddFinalizer, fmt.Sprintf("Failed add finalizer due to %v", err))
+		return ctrlerrors.NewErrorWithMetrics(controllerName, MetricErrorAddFinalizers, err, r.metricsCollector)
+	}
+
+	// TODO: Implement GlobalAccelerator resource management
+	// This would include:
+	// 1. Creating/updating AWS Global Accelerator
+	// 2. Managing listeners and endpoint groups
+	// 3. Handling endpoint discovery from Services/Ingresses/Gateways
+	reconcileResourceFn := func() {
+		err = r.reconcileGlobalAcceleratorResources(ctx, ga)
+	}
+	r.metricsCollector.ObserveControllerReconcileLatency(controllerName, MetricStageReconcileGlobalAccelerator, reconcileResourceFn)
+	if err != nil {
+		return ctrlerrors.NewErrorWithMetrics(controllerName, MetricErrorReconcileGlobalAccelerator, err, r.metricsCollector)
+	}
+
+	r.eventRecorder.Event(ga, corev1.EventTypeNormal, k8s.GlobalAcceleratorEventReasonSuccessfullyReconciled, "Successfully reconciled")
+	return nil
+}
+
+func (r *globalAcceleratorReconciler) cleanupGlobalAccelerator(ctx context.Context, ga *agaapi.GlobalAccelerator) error {
+	if k8s.HasFinalizer(ga, shared_constants.GlobalAcceleratorFinalizer) {
+		// TODO: Implement cleanup logic for AWS Global Accelerator resources
+		if err := r.cleanupGlobalAcceleratorResources(ctx, ga); err != nil {
+			r.eventRecorder.Event(ga, corev1.EventTypeWarning, k8s.GlobalAcceleratorEventReasonFailedCleanup, fmt.Sprintf("Failed cleanup due to %v", err))
+			return err
+		}
+		if err := r.finalizerManager.RemoveFinalizers(ctx, ga, shared_constants.GlobalAcceleratorFinalizer); err != nil {
+			r.eventRecorder.Event(ga, corev1.EventTypeWarning, k8s.GlobalAcceleratorEventReasonFailedRemoveFinalizer, fmt.Sprintf("Failed remove finalizer due to %v", err))
+			return err
+		}
+	}
+	return nil
+}
+
+func (r *globalAcceleratorReconciler) reconcileGlobalAcceleratorResources(ctx context.Context, ga *agaapi.GlobalAccelerator) error {
+	// TODO: Implement the actual AWS Global Accelerator resource management
+	// This is a placeholder implementation
+	r.logger.Info("Reconciling GlobalAccelerator resources", "name", ga.Name, "namespace", ga.Namespace)
+
+	return nil
+}
+
+func (r *globalAcceleratorReconciler) cleanupGlobalAcceleratorResources(ctx context.Context, ga *agaapi.GlobalAccelerator) error {
+	// TODO: Implement the actual AWS Global Accelerator resource cleanup
+	// This is a placeholder implementation
+	r.logger.Info("Cleaning up GlobalAccelerator resources", "name", ga.Name, "namespace", ga.Namespace)
+	return nil
+}
+
+func (r *globalAcceleratorReconciler) SetupWithManager(ctx context.Context, mgr ctrl.Manager) error {
+	if err := r.setupIndexes(ctx, mgr.GetFieldIndexer()); err != nil {
+		return err
+	}
+
+	// TODO: Add event handlers for Services, Ingresses, and Gateways
+	// that are referenced by GlobalAccelerator endpoints
+
+	return ctrl.NewControllerManagedBy(mgr).
+		For(&agaapi.GlobalAccelerator{}).
+		Named(controllerName).
+		WithOptions(controller.Options{
+			MaxConcurrentReconciles: r.maxConcurrentReconciles,
+		}).
+		Complete(r)
+}
+
+func (r *globalAcceleratorReconciler) setupIndexes(ctx context.Context, fieldIndexer client.FieldIndexer) error {
+	// TODO: Add field indexes for efficient lookups
+	return nil
+}

helm/aws-load-balancer-controller/templates/rbac.yaml

@@ -119,6 +119,15 @@ rules:
 - apiGroups: ["gateway.networking.k8s.io"]
   resources: [grpcroutes/status, httproutes/status, tcproutes/status, tlsroutes/status, udproutes/status]
   verbs: [get, patch, update]
+- apiGroups: ["aga.k8s.aws"]
+  resources: [globalaccelerators]
+  verbs: [get, list, patch, watch]
+- apiGroups: ["aga.k8s.aws"]
+  resources: [globalaccelerators/finalizers]
+  verbs: [patch, update]
+- apiGroups: ["aga.k8s.aws"]
+  resources: [globalaccelerators/status]
+  verbs: [patch, update]
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding

helm/aws-load-balancer-controller/values.yaml

@@ -375,6 +375,7 @@ controllerConfig:
   # NLBHealthCheckAdvancedConfig: true
   # ALBSingleSubnet: false
   # LBCapacityReservation: true
+  # AGAController: true
   # EnhancedDefaultBehavior: false
 
 certDiscovery:

main.go

@@ -45,7 +45,9 @@ import (
 	clientgoscheme "k8s.io/client-go/kubernetes/scheme"
 	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
 	"k8s.io/klog/v2"
+	agaapi "sigs.k8s.io/aws-load-balancer-controller/apis/aga/v1beta1"
 	elbv2api "sigs.k8s.io/aws-load-balancer-controller/apis/elbv2/v1beta1"
+	agacontroller "sigs.k8s.io/aws-load-balancer-controller/controllers/aga"
 	elbv2controller "sigs.k8s.io/aws-load-balancer-controller/controllers/elbv2"
 	"sigs.k8s.io/aws-load-balancer-controller/controllers/ingress"
 	"sigs.k8s.io/aws-load-balancer-controller/controllers/service"
@@ -79,6 +81,7 @@ var (
 func init() {
 	_ = clientgoscheme.AddToScheme(scheme)
 
+	_ = agaapi.AddToScheme(scheme)
 	_ = elbv2api.AddToScheme(scheme)
 	_ = elbv2gw.AddToScheme(scheme)
 	_ = gwv1.AddToScheme(scheme)
@@ -226,6 +229,16 @@ func main() {
 		os.Exit(1)
 	}
 
+	// Setup GlobalAccelerator controller only if enabled
+	if controllerCFG.FeatureGates.Enabled(config.AGAController) {
+		agaReconciler := agacontroller.NewGlobalAcceleratorReconciler(mgr.GetClient(), mgr.GetEventRecorderFor("globalAccelerator"),
+			finalizerManager, controllerCFG, ctrl.Log.WithName("controllers").WithName("globalAccelerator"), lbcMetricsCollector, reconcileCounters)
+		if err := agaReconciler.SetupWithManager(ctx, mgr); err != nil {
+			setupLog.Error(err, "unable to create controller", "controller", "GlobalAccelerator")
+			os.Exit(1)
+		}
+	}
+
 	// Initialize common gateway configuration
 	if controllerCFG.FeatureGates.Enabled(config.NLBGatewayAPI) || controllerCFG.FeatureGates.Enabled(config.ALBGatewayAPI) {
 

pkg/config/controller_config.go

@@ -26,6 +26,7 @@ const (
 	flagGatewayClassMaxConcurrentReconciles          = "gateway-class-max-concurrent-reconciles"
 	flagALBGatewayMaxConcurrentReconciles            = "alb-gateway-max-concurrent-reconciles"
 	flagNLBGatewayMaxConcurrentReconciles            = "nlb-gateway-max-concurrent-reconciles"
+	flagGlobalAcceleratorMaxConcurrentReconciles     = "globalaccelerator-max-concurrent-reconciles"
 	flagTargetGroupBindingMaxExponentialBackoffDelay = "targetgroupbinding-max-exponential-backoff-delay"
 	flagLbStabilizationMonitorInterval               = "lb-stabilization-monitor-interval"
 	flagDefaultSSLPolicy                             = "default-ssl-policy"
@@ -119,6 +120,9 @@ type ControllerConfig struct {
 	// NLBGatewayMaxConcurrentReconciles Max concurrent reconcile loops for NLB Gateway objects
 	NLBGatewayMaxConcurrentReconciles int
 
+	// GlobalAcceleratorMaxConcurrentReconciles Max concurrent reconcile loops for GlobalAccelerator objects
+	GlobalAcceleratorMaxConcurrentReconciles int
+
 	// EnableBackendSecurityGroup specifies whether to use optimized security group rules
 	EnableBackendSecurityGroup bool
 
@@ -164,6 +168,8 @@ func (cfg *ControllerConfig) BindFlags(fs *pflag.FlagSet) {
 		"Maximum number of concurrently running reconcile loops for alb gateway")
 	fs.IntVar(&cfg.NLBGatewayMaxConcurrentReconciles, flagNLBGatewayMaxConcurrentReconciles, defaultMaxConcurrentReconciles,
 		"Maximum number of concurrently running reconcile loops for nlb gateway")
+	fs.IntVar(&cfg.GlobalAcceleratorMaxConcurrentReconciles, flagGlobalAcceleratorMaxConcurrentReconciles, defaultMaxConcurrentReconciles,
+		"Maximum number of concurrently running reconcile loops for globalAccelerator")
 	fs.DurationVar(&cfg.TargetGroupBindingMaxExponentialBackoffDelay, flagTargetGroupBindingMaxExponentialBackoffDelay, defaultMaxExponentialBackoffDelay,
 		"Maximum duration of exponential backoff for targetGroupBinding reconcile failures")
 	fs.DurationVar(&cfg.LBStabilizationMonitorInterval, flagLbStabilizationMonitorInterval, defaultLbStabilizationMonitorInterval,

pkg/config/feature_gates.go

@@ -27,6 +27,7 @@ const (
 	SubnetDiscoveryByReachability Feature = "SubnetDiscoveryByReachability"
 	NLBGatewayAPI                 Feature = "NLBGatewayAPI"
 	ALBGatewayAPI                 Feature = "ALBGatewayAPI"
+	AGAController                 Feature = "AGAController"
 	EnhancedDefaultBehavior       Feature = "EnhancedDefaultBehavior"
 )
 
@@ -70,6 +71,7 @@ func NewFeatureGates() FeatureGates {
 			LBCapacityReservation:         true,
 			NLBGatewayAPI:                 false,
 			ALBGatewayAPI:                 false,
+			AGAController:                 true,
 			EnableTCPUDPListenerType:      false,
 			EnhancedDefaultBehavior:       false,
 		},

pkg/k8s/events.go

@@ -45,4 +45,11 @@ const (
 	// Load Balancer Configuration events
 	LoadBalancerConfigurationEventReasonFailedAddFinalizer    = "FailedAddFinalizer"
 	LoadBalancerConfigurationEventReasonFailedRemoveFinalizer = "FailedRemoveFinalizer"
+
+	// GlobalAccelerator events
+	GlobalAcceleratorEventReasonFailedAddFinalizer     = "FailedAddFinalizer"
+	GlobalAcceleratorEventReasonFailedRemoveFinalizer  = "FailedRemoveFinalizer"
+	GlobalAcceleratorEventReasonFailedUpdateStatus     = "FailedUpdateStatus"
+	GlobalAcceleratorEventReasonFailedCleanup          = "FailedCleanup"
+	GlobalAcceleratorEventReasonSuccessfullyReconciled = "SuccessfullyReconciled"
 )

pkg/metrics/util/reconcile_counter.go

@@ -8,12 +8,13 @@ import (
 )
 
 type ReconcileCounters struct {
-	serviceReconciles    map[types.NamespacedName]int
-	ingressReconciles    map[types.NamespacedName]int
-	tgbReconciles        map[types.NamespacedName]int
-	nlbGatewayReconciles map[types.NamespacedName]int
-	albGatewayReconciles map[types.NamespacedName]int
-	mutex                sync.Mutex
+	serviceReconciles           map[types.NamespacedName]int
+	ingressReconciles           map[types.NamespacedName]int
+	tgbReconciles               map[types.NamespacedName]int
+	nlbGatewayReconciles        map[types.NamespacedName]int
+	albGatewayReconciles        map[types.NamespacedName]int
+	globalAcceleratorReconciles map[types.NamespacedName]int
+	mutex                       sync.Mutex
 }
 
 type ResourceReconcileCount struct {
@@ -23,12 +24,13 @@ type ResourceReconcileCount struct {
 
 func NewReconcileCounters() *ReconcileCounters {
 	return &ReconcileCounters{
-		serviceReconciles:    make(map[types.NamespacedName]int),
-		ingressReconciles:    make(map[types.NamespacedName]int),
-		tgbReconciles:        make(map[types.NamespacedName]int),
-		albGatewayReconciles: make(map[types.NamespacedName]int),
-		nlbGatewayReconciles: make(map[types.NamespacedName]int),
-		mutex:                sync.Mutex{},
+		serviceReconciles:           make(map[types.NamespacedName]int),
+		ingressReconciles:           make(map[types.NamespacedName]int),
+		tgbReconciles:               make(map[types.NamespacedName]int),
+		albGatewayReconciles:        make(map[types.NamespacedName]int),
+		nlbGatewayReconciles:        make(map[types.NamespacedName]int),
+		globalAcceleratorReconciles: make(map[types.NamespacedName]int),
+		mutex:                       sync.Mutex{},
 	}
 }
 
@@ -61,6 +63,12 @@ func (c *ReconcileCounters) IncrementALBGateway(namespaceName types.NamespacedNa
 	defer c.mutex.Unlock()
 	c.albGatewayReconciles[namespaceName]++
 }
+
+func (c *ReconcileCounters) IncrementAGA(namespaceName types.NamespacedName) {
+	c.mutex.Lock()
+	defer c.mutex.Unlock()
+	c.globalAcceleratorReconciles[namespaceName]++
+}
 func (c *ReconcileCounters) GetTopReconciles(n int) map[string][]ResourceReconcileCount {
 	c.mutex.Lock()
 	defer c.mutex.Unlock()
@@ -85,6 +93,7 @@ func (c *ReconcileCounters) GetTopReconciles(n int) map[string][]ResourceReconci
 	topReconciles["targetgroupbinding"] = getTopN(c.tgbReconciles)
 	topReconciles["nlbgateway"] = getTopN(c.nlbGatewayReconciles)
 	topReconciles["albgateway"] = getTopN(c.albGatewayReconciles)
+	topReconciles["globalaccelerator"] = getTopN(c.globalAcceleratorReconciles)
 
 	return topReconciles
 }
@@ -97,4 +106,5 @@ func (c *ReconcileCounters) ResetCounter() {
 	c.tgbReconciles = make(map[types.NamespacedName]int)
 	c.nlbGatewayReconciles = make(map[types.NamespacedName]int)
 	c.albGatewayReconciles = make(map[types.NamespacedName]int)
+	c.globalAcceleratorReconciles = make(map[types.NamespacedName]int)
 }

pkg/shared_constants/finalizers.go

@@ -27,4 +27,7 @@ const (
 
 	// ListenerRuleConfigurationFinalizer the finalizer we attach to a listener rule configuration resource
 	ListenerRuleConfigurationFinalizer = "gateway.k8s.aws/listenerruleconfigurations"
+
+	// GlobalAcceleratorFinalizer the finalizer we attach to a global accelerator resource
+	GlobalAcceleratorFinalizer = "aga.k8s.aws/resources"
 )