Merge pull request #198 from phanimarupaka/FailApplyPreviewForRequiredSetters

Fail Apply/Preview for Required Setters

Author: k8s-ci-robot

cmd/apply/cmdapply.go

@@ -18,6 +18,7 @@ import (
 	"sigs.k8s.io/cli-utils/pkg/apply"
 	"sigs.k8s.io/cli-utils/pkg/common"
 	"sigs.k8s.io/cli-utils/pkg/manifestreader"
+	"sigs.k8s.io/kustomize/kyaml/setters2"
 )
 
 func GetApplyRunner(f cmdutil.Factory, ioStreams genericclioptions.IOStreams) *ApplyRunner {
@@ -85,6 +86,7 @@ type ApplyRunner struct {
 }
 
 func (r *ApplyRunner) RunE(cmd *cobra.Command, args []string) error {
+	cmdutil.CheckErr(setters2.CheckRequiredSettersSet())
 	prunePropPolicy, err := convertPropagationPolicy(r.prunePropagationPolicy)
 	if err != nil {
 		return err

cmd/preview/cmdpreview.go

@@ -15,6 +15,7 @@ import (
 	"sigs.k8s.io/cli-utils/pkg/apply/event"
 	"sigs.k8s.io/cli-utils/pkg/common"
 	"sigs.k8s.io/cli-utils/pkg/manifestreader"
+	"sigs.k8s.io/kustomize/kyaml/setters2"
 )
 
 var (
@@ -36,6 +37,7 @@ func NewCmdPreview(f cmdutil.Factory, ioStreams genericclioptions.IOStreams) *co
 		Short:                 i18n.T("Preview the apply of a configuration"),
 		Args:                  cobra.MaximumNArgs(1),
 		Run: func(cmd *cobra.Command, args []string) {
+			cmdutil.CheckErr(setters2.CheckRequiredSettersSet())
 			var ch <-chan event.Event
 			cmdutil.CheckErr(destroyer.Initialize(cmd, args))
 			// if destroy flag is set in preview, transmit it to destroyer DryRun flag

go.mod

@@ -7,7 +7,7 @@ require (
 	github.com/golang/groupcache v0.0.0-20190129154638-5b532d6fd5ef // indirect
 	github.com/google/uuid v1.1.1
 	github.com/pkg/errors v0.9.1
-	github.com/spf13/cobra v0.0.5
+	github.com/spf13/cobra v1.0.0
 	github.com/stretchr/testify v1.4.0
 	go.uber.org/atomic v1.4.0 // indirect
 	golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550 // indirect
@@ -23,6 +23,6 @@ require (
 	k8s.io/kubectl v0.0.0-20191219154910-1528d4eea6dd
 	k8s.io/utils v0.0.0-20191114184206-e782cd3c129f
 	sigs.k8s.io/controller-runtime v0.4.0
-	sigs.k8s.io/kustomize/kyaml v0.1.4
+	sigs.k8s.io/kustomize/kyaml v0.3.5-0.20200706010650-855ce1a8db6c
 	sigs.k8s.io/yaml v1.2.0
 )