Skip to content

Commit fed1e9c

Browse files
committed
Add more tests
1 parent 22da8ec commit fed1e9c

File tree

3 files changed

+640
-399
lines changed

3 files changed

+640
-399
lines changed

config/crd/bases/infrastructure.cluster.x-k8s.io_rosaroleconfigs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
33
kind: CustomResourceDefinition
44
metadata:
55
annotations:
6-
controller-gen.kubebuilder.io/version: v0.17.3
6+
controller-gen.kubebuilder.io/version: v0.19.0
77
name: rosaroleconfigs.infrastructure.cluster.x-k8s.io
88
spec:
99
group: infrastructure.cluster.x-k8s.io

exp/controllers/rosaroleconfig_controller.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,11 @@ func (r *ROSARoleConfigReconciler) Reconcile(ctx context.Context, req ctrl.Reque
113113
defer func() {
114114
conditions.SetSummary(scope.RosaRoleConfig, conditions.WithConditions(expinfrav1.RosaRoleConfigReadyCondition), conditions.WithStepCounter())
115115

116-
if err := scope.PatchObject(); err != nil {
117-
reterr = errors.Join(reterr, err)
116+
// Delete is already patched
117+
if roleConfig.ObjectMeta.DeletionTimestamp.IsZero() {
118+
if err := scope.PatchObject(); err != nil {
119+
reterr = errors.Join(reterr, err)
120+
}
118121
}
119122
}()
120123

0 commit comments

Comments
 (0)