Skip to content

Commit 690a021

Browse files
committed
Fix new events API manager leak detection test
Signed-off-by: Borja Clemente <[email protected]>
1 parent 599683d commit 690a021

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

pkg/manager/manager_test.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@ import (
3636
"go.uber.org/goleak"
3737
coordinationv1 "k8s.io/api/coordination/v1"
3838
corev1 "k8s.io/api/core/v1"
39+
eventsv1 "k8s.io/api/events/v1"
3940
"k8s.io/apimachinery/pkg/api/meta"
41+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
42+
"k8s.io/apimachinery/pkg/fields"
4043
"k8s.io/apimachinery/pkg/runtime"
4144
"k8s.io/apimachinery/pkg/runtime/schema"
4245
"k8s.io/client-go/rest"
@@ -1878,8 +1881,9 @@ var _ = Describe("manger.Manager", func() {
18781881
}()
18791882
<-m.Elected()
18801883

1881-
Eventually(func() *corev1.Event {
1882-
evts, err := clientset.CoreV1().Events("").SearchWithContext(ctx, m.GetScheme(), &ns)
1884+
Eventually(func() *eventsv1.Event {
1885+
evts, err := clientset.EventsV1().Events("").List(ctx,
1886+
metav1.ListOptions{FieldSelector: fields.OneTermEqualSelector("regarding.name", ns.Name).String()})
18831887
Expect(err).NotTo(HaveOccurred())
18841888

18851889
for i, evt := range evts.Items {
@@ -1914,7 +1918,7 @@ var _ = Describe("manger.Manager", func() {
19141918
Expect(err).NotTo(HaveOccurred())
19151919

19161920
// Add the slow runnable that will return an error after some delay
1917-
for i := 0; i < 3; i++ {
1921+
for range 3 {
19181922
slowRunnable := RunnableFunc(func(c context.Context) error {
19191923
<-c.Done()
19201924

0 commit comments

Comments
 (0)