Potential ordering issue with pinning the proxmox kernel

[btravouillon]

With 1.9.0 (and #267), the pinning of the kernel is executed after the tasks Run apt-get dist-upgrade on repository changes and Perform system upgrades. This may lead to unexpected behaviour.

For example, I just ran the 1.9.0 on a node with -e pve_run_system_upgrades=true, after removing pve_default_kernel_version from my inventory. This removed /etc/apt/preferences.d/proxmox-default-kernel as expected, but the kernel was not upgraded. I had to run the playbook twice to upgrade the kernel.

In the case of a repo change or required system upgrades, I also believe this could install the latest kernel first, then pin the proxmox-default-kernel to a previous pve_default_kernel_version.

I'm not sure if this is on purpose or not, otherwise I would have opened an MR to fix this already.

Info

Running up-to-date Proxmox VE 8.2.7 community.

[lae]

Mmm, I guess it's because pve-default-kernel doesn't get pulled into the list of packages in the package installation step that follows on already provisioned systems...?

Moving it before dist-upgrade is fine I think (or however you were considering fixing it). Right now it sounds like it mainly works on new installs but not if modifying that value afterwards.

In the case of a repo change or required system upgrades, I also believe this could install the latest kernel first, then pin the proxmox-default-kernel to a previous pve_default_kernel_version.

This shouldn't be true unless the variable is also being set or modified in the same playbook run, cause the preferences file should be there already.