Fixing missing use in CRUDdy controller tests

Author: spekulatius

src/Generators/TestGenerator.php

@@ -107,6 +107,8 @@ protected function buildTestCases(Controller $controller)
                 : config('blueprint.namespace');
 
             if (in_array($name, ['edit', 'update', 'show', 'destroy'])) {
+                $this->addImport($controller, $modelNamespace . '\\' . $model);
+
                 $setup['data'][] = sprintf('$%s = %s::factory()->create();', $variable, $model);
             }
 

tests/Feature/Generators/TestGeneratorTest.php

@@ -70,11 +70,12 @@ public function output_generates_test_for_controller_tree_l8($definition, $path,
                 ->with($dirname, 0755, true);
 
             $this->filesystem->expects('put')
-            ->with($path, $this->fixture($test));
+                ->with($path, $this->fixture($test));
         }
 
         $tokens = $this->blueprint->parse($this->fixture($definition));
         $tree = $this->blueprint->analyze($tokens);
+
         $this->assertEquals(['created' => array_keys($paths)], $this->subject->output($tree));
     }
 
@@ -97,17 +98,20 @@ public function output_works_for_pascal_case_definition_l8()
         $this->filesystem->expects('exists')
             ->with(dirname($certificateControllerTest))
             ->andReturnTrue();
+
         $this->filesystem->expects('put')
             ->with($certificateControllerTest, $this->fixture('tests/certificate-pascal-case-example.php'));
 
         $this->filesystem->expects('exists')
             ->with(dirname($certificateTypeControllerTest))
             ->andReturnTrue();
+
         $this->filesystem->expects('put')
             ->with($certificateTypeControllerTest, $this->fixture('tests/certificate-type-pascal-case-example.php'));
 
         $tokens = $this->blueprint->parse($this->fixture('drafts/pascal-case.yaml'));
         $tree = $this->blueprint->analyze($tokens);
+
         $this->assertEquals(['created' => [$certificateControllerTest, $certificateTypeControllerTest]], $this->subject->output($tree));
     }
 
@@ -123,11 +127,14 @@ public function output_generates_test_for_controller_tree_using_cached_model_l8(
         $this->filesystem->expects('stub')
             ->with('test.case.stub')
             ->andReturn($this->stub('test.case.stub'));
+
         $this->filesystem->expects('exists')
             ->with('tests/Feature/Http/Controllers')
             ->andReturnFalse();
+
         $this->filesystem->expects('makeDirectory')
             ->with('tests/Feature/Http/Controllers', 0755, true);
+
         $this->filesystem->expects('put')
             ->with('tests/Feature/Http/Controllers/UserControllerTest.php', $this->fixture('tests/reference-cache.php'));
 
@@ -161,17 +168,21 @@ public function output_generates_tests_with_models_with_custom_namespace_correct
         $this->filesystem->expects('stub')
             ->with('test.case.stub')
             ->andReturn($this->stub('test.case.stub'));
+
         $dirname = dirname($path);
         $this->filesystem->expects('exists')
             ->with($dirname)
             ->andReturnFalse();
+
         $this->filesystem->expects('makeDirectory')
-        ->with($dirname, 0755, true);
+            ->with($dirname, 0755, true);
+
         $this->filesystem->expects('put')
             ->with($path, $this->fixture($test));
 
         $tokens = $this->blueprint->parse($this->fixture($definition));
         $tree = $this->blueprint->analyze($tokens);
+
         $this->assertEquals(['created' => [$path]], $this->subject->output($tree));
     }
 
@@ -187,8 +198,8 @@ public function output_using_return_types()
         $this->app['config']->set('blueprint.use_return_types', true);
 
         $this->filesystem->expects('stub')
-        ->with('test.class.stub')
-        ->andReturn($this->stub('test.class.stub'));
+            ->with('test.class.stub')
+            ->andReturn($this->stub('test.class.stub'));
 
         $this->filesystem->expects('stub')
             ->with('test.case.stub')
@@ -219,6 +230,7 @@ public function controllerTreeDataProvider()
             ['drafts/readme-example-notification-model.yaml', 'tests/Feature/Http/Controllers/PostControllerTest.php', 'tests/readme-example-notification.php'],
             ['drafts/respond-statements.yaml', 'tests/Feature/Http/Controllers/Api/PostControllerTest.php', 'tests/respond-statements.php'],
             ['drafts/full-crud-example.yaml', 'tests/Feature/Http/Controllers/PostControllerTest.php', 'tests/full-crud-example.php'],
+            ['drafts/crud-show-only.yaml', 'tests/Feature/Http/Controllers/PostControllerTest.php', 'tests/crud-show-only.php'],
             ['drafts/model-reference-validate.yaml', 'tests/Feature/Http/Controllers/CertificateControllerTest.php', 'tests/api-shorthand-validation.php'],
             ['drafts/controllers-only-no-context.yaml', 'tests/Feature/Http/Controllers/ReportControllerTest.php', 'tests/controllers-only-no-context.php'],
             ['drafts/call-to-a-member-function-columns-on-null.yaml', [

tests/fixtures/drafts/crud-show-only.yaml

@@ -0,0 +1,10 @@
+models:
+  Post:
+    title: string:400
+    content: longtext
+    published_at: nullable timestamp
+
+controllers:
+  Post:
+    show:
+      render: posts.show with:post

tests/fixtures/tests/crud-show-only.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace Tests\Feature\Http\Controllers;
+
+use App\Models\Post;
+use Tests\TestCase;
+
+/**
+ * @see \App\Http\Controllers\PostController
+ */
+class PostControllerTest extends TestCase
+{
+    /**
+     * @test
+     */
+    public function show_displays_view()
+    {
+        $post = Post::factory()->create();
+
+        $response = $this->get(route('post.show', $post));
+
+        $response->assertOk();
+        $response->assertViewIs('posts.show');
+        $response->assertViewHas('post');
+    }
+}