Ensure all generated directories exist

jasonmccreary · jasonmccreary · commit d1bdf11733e2 · 2020-02-13T09:32:14.000-05:00
diff --git a/src/Generators/Statements/EventGenerator.php b/src/Generators/Statements/EventGenerator.php
@@ -42,7 +42,7 @@ public function output(array $tree): array
                     }
 
                     if (!$this->files->exists(dirname($path))) {
-                        $this->files->makeDirectory(dirname($path));
+                        $this->files->makeDirectory(dirname($path), 0755, true);
                     }
 
                     $this->files->put(
diff --git a/src/Generators/Statements/FormRequestGenerator.php b/src/Generators/Statements/FormRequestGenerator.php
@@ -49,7 +49,7 @@ public function output(array $tree): array
                     }
 
                     if (!$this->files->exists(dirname($path))) {
-                        $this->files->makeDirectory(dirname($path));
+                        $this->files->makeDirectory(dirname($path), 0755, true);
                     }
 
                     $this->files->put(
diff --git a/src/Generators/Statements/JobGenerator.php b/src/Generators/Statements/JobGenerator.php
@@ -38,7 +38,7 @@ public function output(array $tree): array
                     }
 
                     if (!$this->files->exists(dirname($path))) {
-                        $this->files->makeDirectory(dirname($path));
+                        $this->files->makeDirectory(dirname($path), 0755, true);
                     }
 
                     $this->files->put(
diff --git a/src/Generators/Statements/MailGenerator.php b/src/Generators/Statements/MailGenerator.php
@@ -38,7 +38,7 @@ public function output(array $tree): array
                     }
 
                     if (!$this->files->exists(dirname($path))) {
-                        $this->files->makeDirectory(dirname($path));
+                        $this->files->makeDirectory(dirname($path), 0755, true);
                     }
 
                     $this->files->put(
diff --git a/src/Generators/Statements/ViewGenerator.php b/src/Generators/Statements/ViewGenerator.php
@@ -39,7 +39,7 @@ public function output(array $tree): array
                     }
 
                     if (!$this->files->exists(dirname($path))) {
-                        $this->files->makeDirectory(dirname($path));
+                        $this->files->makeDirectory(dirname($path), 0755, true);
                     }
 
                     $this->files->put(
diff --git a/src/Generators/TestGenerator.php b/src/Generators/TestGenerator.php
@@ -49,6 +49,11 @@ public function output(array $tree): array
         /** @var \Blueprint\Models\Controller $controller */
         foreach ($tree['controllers'] as $controller) {
             $path = $this->getPath($controller);
+
+            if (!$this->files->exists(dirname($path))) {
+                $this->files->makeDirectory(dirname($path), 0755, true);
+            }
+
             $this->files->put(
                 $path,
                 $this->populateStub($stub, $controller)
diff --git a/tests/Feature/Generator/Statements/EventGeneratorTest.php b/tests/Feature/Generator/Statements/EventGeneratorTest.php
@@ -83,7 +83,7 @@ public function output_writes_events()
             ->with('app/Events/UserCreated.php')
             ->andReturnFalse();
         $this->files->expects('makeDirectory')
-            ->with('app/Events');
+            ->with('app/Events', 0755, true);
         $this->files->expects('put')
             ->with('app/Events/UserCreated.php', $this->fixture('events/user-created.php'));
 
@@ -137,7 +137,7 @@ public function it_respects_configuration()
             ->with('src/path/Events')
             ->andReturnFalse();
         $this->files->expects('makeDirectory')
-            ->with('src/path/Events');
+            ->with('src/path/Events', 0755, true);
         $this->files->expects('exists')
             ->with('src/path/Events/NewPost.php')
             ->andReturnFalse();
diff --git a/tests/Feature/Generator/Statements/FormRequestGeneratorTest.php b/tests/Feature/Generator/Statements/FormRequestGeneratorTest.php
@@ -80,7 +80,7 @@ public function output_writes_form_requests()
             ->with('app/Http/Requests/PostIndexRequest.php')
             ->andReturnFalse();
         $this->files->expects('makeDirectory')
-            ->with('app/Http/Requests');
+            ->with('app/Http/Requests', 0755, true);
         $this->files->expects('put')
             ->with('app/Http/Requests/PostIndexRequest.php', $this->fixture('form-requests/post-index.php'));
 
@@ -143,7 +143,7 @@ public function output_supports_nested_form_requests()
             ->with('app/Http/Requests/Admin/UserStoreRequest.php')
             ->andReturnFalse();
         $this->files->expects('makeDirectory')
-            ->with('app/Http/Requests/Admin');
+            ->with('app/Http/Requests/Admin', 0755, true);
         $this->files->expects('put')
             ->with('app/Http/Requests/Admin/UserStoreRequest.php', $this->fixture('form-requests/nested-components.php'));
 
@@ -172,7 +172,7 @@ public function it_respects_configuration()
             ->with('src/path/Http/Requests/PostStoreRequest.php')
             ->andReturnFalse();
         $this->files->expects('makeDirectory')
-            ->with('src/path/Http/Requests');
+            ->with('src/path/Http/Requests', 0755, true);
         $this->files->expects('put')
             ->with('src/path/Http/Requests/PostStoreRequest.php', $this->fixture('form-requests/form-request-configured.php'));
 
diff --git a/tests/Feature/Generator/Statements/JobGeneratorTest.php b/tests/Feature/Generator/Statements/JobGeneratorTest.php
@@ -83,7 +83,7 @@ public function output_writes_jobs()
             ->with('app/Jobs/CreateUser.php')
             ->andReturnFalse();
         $this->files->expects('makeDirectory')
-            ->with('app/Jobs');
+            ->with('app/Jobs', 0755, true);
         $this->files->expects('put')
             ->with('app/Jobs/CreateUser.php', $this->fixture('jobs/create-user.php'));
 
@@ -140,7 +140,7 @@ public function it_respects_configuration()
             ->with('src/path/Jobs/SyncMedia.php')
             ->andReturnFalse();
         $this->files->expects('makeDirectory')
-            ->with('src/path/Jobs');
+            ->with('src/path/Jobs', 0755, true);
         $this->files->expects('put')
             ->with('src/path/Jobs/SyncMedia.php', $this->fixture('jobs/job-configured.php'));
 
diff --git a/tests/Feature/Generator/Statements/MailGeneratorTest.php b/tests/Feature/Generator/Statements/MailGeneratorTest.php
@@ -83,7 +83,7 @@ public function output_writes_mails()
             ->with('app/Mail/ReviewPost.php')
             ->andReturnFalse();
         $this->files->expects('makeDirectory')
-            ->with('app/Mail');
+            ->with('app/Mail', 0755, true);
         $this->files->expects('put')
             ->with('app/Mail/ReviewPost.php', $this->fixture('mailables/review-post.php'));
 
@@ -140,7 +140,7 @@ public function it_respects_configuration()
             ->with('src/path/Mail/ReviewNotification.php')
             ->andReturnFalse();
         $this->files->expects('makeDirectory')
-            ->with('src/path/Mail');
+            ->with('src/path/Mail', 0755, true);
         $this->files->expects('put')
             ->with('src/path/Mail/ReviewNotification.php', $this->fixture('mailables/mail-configured.php'));
 
diff --git a/tests/Feature/Generator/Statements/ViewGeneratorTest.php b/tests/Feature/Generator/Statements/ViewGeneratorTest.php
@@ -95,8 +95,7 @@ public function output_writes_views_for_render_statements()
             ->with('resources/views/post/show.blade.php')
             ->andReturnFalse();
         $this->files->expects('makeDirectory')
-            ->with('resources/views/post')
-            ->andReturnFalse();
+            ->with('resources/views/post', 0755, true);
         $this->files->expects('put')
             ->with('resources/views/post/show.blade.php', str_replace('DummyView', 'post.show', $template));
 
diff --git a/tests/Feature/Generator/TestGeneratorTest.php b/tests/Feature/Generator/TestGeneratorTest.php
@@ -59,7 +59,11 @@ public function output_writes_migration_for_controller_tree($definition, $path,
         $this->files->expects('get')
             ->with('stubs/test/case.stub')
             ->andReturn(file_get_contents('stubs/test/case.stub'));
-
+        $this->files->expects('exists')
+            ->with('tests/Feature/Http/Controllers')
+            ->andReturnFalse();
+        $this->files->expects('makeDirectory')
+            ->with('tests/Feature/Http/Controllers', 0755, true);
         $this->files->expects('put')
             ->with($path, $this->fixture($test));
 

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function output(array $tree): array`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`if (!$this->files->exists(dirname($path))) {`
`45`		`- $this->files->makeDirectory(dirname($path));`
	`45`	`+ $this->files->makeDirectory(dirname($path), 0755, true);`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`$this->files->put(`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public function output(array $tree): array`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`if (!$this->files->exists(dirname($path))) {`
`52`		`- $this->files->makeDirectory(dirname($path));`
	`52`	`+ $this->files->makeDirectory(dirname($path), 0755, true);`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`$this->files->put(`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function output(array $tree): array`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`if (!$this->files->exists(dirname($path))) {`
`41`		`- $this->files->makeDirectory(dirname($path));`
	`41`	`+ $this->files->makeDirectory(dirname($path), 0755, true);`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`$this->files->put(`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function output(array $tree): array`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`if (!$this->files->exists(dirname($path))) {`
`42`		`- $this->files->makeDirectory(dirname($path));`
	`42`	`+ $this->files->makeDirectory(dirname($path), 0755, true);`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`$this->files->put(`