Generate simple assertions for resource statements (#290)

Author: jasonmccreary

src/Generators/TestGenerator.php

@@ -12,6 +12,7 @@
 use Blueprint\Models\Statements\QueryStatement;
 use Blueprint\Models\Statements\RedirectStatement;
 use Blueprint\Models\Statements\RenderStatement;
+use Blueprint\Models\Statements\ResourceStatement;
 use Blueprint\Models\Statements\RespondStatement;
 use Blueprint\Models\Statements\SendStatement;
 use Blueprint\Models\Statements\SessionStatement;
@@ -376,6 +377,9 @@ protected function buildTestCases(Controller $controller)
                     $assertion .= '));';
 
                     array_unshift($assertions['response'], $assertion);
+                } elseif ($statement instanceof ResourceStatement) {
+                    $assertions['response'][] = '$response->assertOk();';
+                    $assertions['response'][] = '$response->assertJsonStructure([]);';
                 } elseif ($statement instanceof RespondStatement) {
                     $tested_bits |= self::TESTS_RESPONDS;
 

tests/fixtures/tests/api-shorthand-validation.php

@@ -24,6 +24,9 @@ public function index_behaves_as_expected()
         $certificates = factory(Certificate::class, 3)->create();
 
         $response = $this->get(route('certificate.index'));
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -67,6 +70,9 @@ public function store_saves()
             ->get();
         $this->assertCount(1, $certificates);
         $certificate = $certificates->first();
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -78,6 +84,9 @@ public function show_behaves_as_expected()
         $certificate = factory(Certificate::class)->create();
 
         $response = $this->get(route('certificate.show', $certificate));
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -115,6 +124,9 @@ public function update_behaves_as_expected()
 
         $certificate->refresh();
 
+        $response->assertOk();
+        $response->assertJsonStructure([]);
+
         $this->assertEquals($name, $certificate->name);
         $this->assertEquals($certificate_type->id, $certificate->certificate_type_id);
         $this->assertEquals($reference, $certificate->reference);

tests/fixtures/tests/certificate-pascal-case-example.php

@@ -24,6 +24,9 @@ public function index_behaves_as_expected()
         $certificates = factory(Certificate::class, 3)->create();
 
         $response = $this->get(route('certificate.index'));
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -67,6 +70,9 @@ public function store_saves()
             ->get();
         $this->assertCount(1, $certificates);
         $certificate = $certificates->first();
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -78,6 +84,9 @@ public function show_behaves_as_expected()
         $certificate = factory(Certificate::class)->create();
 
         $response = $this->get(route('certificate.show', $certificate));
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -115,6 +124,9 @@ public function update_behaves_as_expected()
 
         $certificate->refresh();
 
+        $response->assertOk();
+        $response->assertJsonStructure([]);
+
         $this->assertEquals($name, $certificate->name);
         $this->assertEquals($certificate_type->id, $certificate->certificate_type_id);
         $this->assertEquals($reference, $certificate->reference);

tests/fixtures/tests/certificate-type-pascal-case-example.php

@@ -23,6 +23,9 @@ public function index_behaves_as_expected()
         $certificateTypes = factory(CertificateType::class, 3)->create();
 
         $response = $this->get(route('certificate-type.index'));
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -54,6 +57,9 @@ public function store_saves()
             ->get();
         $this->assertCount(1, $certificateTypes);
         $certificateType = $certificateTypes->first();
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -65,6 +71,9 @@ public function show_behaves_as_expected()
         $certificateType = factory(CertificateType::class)->create();
 
         $response = $this->get(route('certificate-type.show', $certificateType));
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -94,6 +103,9 @@ public function update_behaves_as_expected()
 
         $certificateType->refresh();
 
+        $response->assertOk();
+        $response->assertJsonStructure([]);
+
         $this->assertEquals($name, $certificateType->name);
     }
 

tests/fixtures/tests/models-with-custom-namespace.php

@@ -23,6 +23,9 @@ public function index_behaves_as_expected()
         $categories = factory(Category::class, 3)->create();
 
         $response = $this->get(route('category.index'));
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -60,6 +63,9 @@ public function store_saves()
             ->get();
         $this->assertCount(1, $categories);
         $category = $categories->first();
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -71,6 +77,9 @@ public function show_behaves_as_expected()
         $category = factory(Category::class)->create();
 
         $response = $this->get(route('category.show', $category));
+
+        $response->assertOk();
+        $response->assertJsonStructure([]);
     }
 
 
@@ -104,6 +113,9 @@ public function update_behaves_as_expected()
 
         $category->refresh();
 
+        $response->assertOk();
+        $response->assertJsonStructure([]);
+
         $this->assertEquals($name, $category->name);
         $this->assertEquals($image, $category->image);
         $this->assertEquals($active, $category->active);