Fix favicon 404s triggered when using loginAs() or logout() methods (#1061)

* return 204 no content

* docblocks

Author: ziadoz

src/Http/Controllers/UserController.php

@@ -33,7 +33,7 @@ public function user($guard = null)
      *
      * @param  string  $userId
      * @param  string|null  $guard
-     * @return void
+     * @return \Illuminate\Http\Response
      */
     public function login($userId, $guard = null)
     {
@@ -46,13 +46,15 @@ public function login($userId, $guard = null)
                     : $provider->retrieveById($userId);
 
         Auth::guard($guard)->login($user);
+
+        return response(status: 204);
     }
 
     /**
      * Log the user out of the application.
      *
      * @param  string|null  $guard
-     * @return void
+     * @return \Illuminate\Http\Response
      */
     public function logout($guard = null)
     {
@@ -61,6 +63,8 @@ public function logout($guard = null)
         Auth::guard($guard)->logout();
 
         Session::forget('password_hash_'.$guard);
+
+        return response(status: 204);
     }
 
     /**