Refactor error handling

Author: driesvints

src/channel/channel.ts

@@ -37,4 +37,9 @@ export abstract class Channel {
     stopListeningForWhisper(event: string): Channel {
         return this.stopListening('.client-' + event);
     }
+
+    /**
+     * Register a callback to be called anytime an error occurs.
+     */
+    abstract error(callback: Function): Channel;
 }

src/channel/null-channel.ts

@@ -32,6 +32,13 @@ export class NullChannel extends Channel {
         return this;
     }
 
+    /**
+     * Register a callback to be called anytime an error occurs.
+     */
+    error(callback: Function): NullChannel {
+        return this;
+    }
+
     /**
      * Bind a channel to an event.
      */

src/channel/null-presence-channel.ts

@@ -12,13 +12,6 @@ export class NullPresenceChannel extends NullChannel implements PresenceChannel
         return this;
     }
 
-    /**
-     * Register a callback to be called anytime an error occurs.
-     */
-    error(callback: Function): NullPresenceChannel {
-        return this;
-    }
-
     /**
      * Listen for someone joining the channel.
      */

src/channel/presence-channel.ts

@@ -7,11 +7,6 @@ export interface PresenceChannel {
      */
     here(callback: Function): PresenceChannel;
 
-    /**
-     * Register a callback to be called anytime an error occurs.
-     */
-    error(callback: Function): PresenceChannel;
-
     /**
      * Listen for someone joining the channel.
      */

src/channel/pusher-channel.ts

@@ -76,6 +76,17 @@ export class PusherChannel extends Channel {
         return this;
     }
 
+    /**
+     * Register a callback to be called anytime a subscription error occurs.
+     */
+    error(callback: Function): PusherChannel {
+        this.on('pusher:subscription_error', (status) => {
+            callback(status);
+        });
+
+        return this;
+    }
+
     /**
      * Bind a channel to an event.
      */

src/channel/pusher-presence-channel.ts

@@ -16,17 +16,6 @@ export class PusherPresenceChannel extends PusherChannel implements PresenceChan
         return this;
     }
 
-    /**
-     * Register a callback to be called anytime a subscription error occurs.
-     */
-    error(callback: Function): PusherPresenceChannel {
-        this.on('pusher:subscription_error', (status) => {
-            callback(status);
-        });
-
-        return this;
-    }
-
     /**
      * Listen for someone joining the channel.
      */

src/channel/socketio-channel.ts

@@ -87,6 +87,13 @@ export class SocketIoChannel extends Channel {
         return this;
     }
 
+    /**
+     * Register a callback to be called anytime an error occurs.
+     */
+    error(callback: Function): SocketIoChannel {
+        return this;
+    }
+
     /**
      * Bind the channel's socket to an event and store the callback.
      */

src/channel/socketio-presence-channel.ts

@@ -16,13 +16,6 @@ export class SocketIoPresenceChannel extends SocketIoPrivateChannel implements P
         return this;
     }
 
-    /**
-     * Register a callback to be called anytime an error occurs.
-     */
-    error(callback: Function): SocketIoPresenceChannel {
-        return this;
-    }
-
     /**
      * Listen for someone joining the channel.
      */