feat:[LAR-32] add visible control in make action

Author: Chri$

app/Filament/Resources/ArticleResource.php

@@ -65,6 +65,7 @@ public static function table(Table $table): Table
             ->actions([
                 ActionGroup::make([
                     Action::make('approved')
+                        ->visible(fn ($record) => $record->submitted_at && (! $record->declined_at && ! $record->approved_at))
                         ->label('Approuver')
                         ->icon('heroicon-s-check')
                         ->color('success')
@@ -74,10 +75,10 @@ public static function table(Table $table): Table
                         ->modalIcon('heroicon-s-check')
                         ->action(function ($record): void {
                             $record->approved_at = now();
-                            $record->declined_at = null;
                             $record->save();
                         }),
                     Action::make('declined')
+                        ->visible(fn ($record) => $record->submitted_at && (! $record->declined_at && ! $record->approved_at))
                         ->label('Décliner')
                         ->icon('heroicon-s-x-mark')
                         ->color('warning')
@@ -87,32 +88,32 @@ public static function table(Table $table): Table
                         ->modalIcon('heroicon-s-x-mark')
                         ->action(function ($record): void {
                             $record->declined_at = now();
-                            $record->approved_at = null;
                             $record->save();
                         }),
-                    // DeclinedAction::make('declined'),
                     Tables\Actions\DeleteAction::make('delete'),
                 ]),
 
             ])
             ->bulkActions([
                 Tables\Actions\BulkActionGroup::make([
                     BulkAction::make('approved')
+                        ->visible(fn (?Collection $records) => ! empty($records) || $records?->contains(fn ($record) => $record->submitted_at))
                         ->label('Approuver la sélection')
                         ->icon('heroicon-s-check')
                         ->color('success')
-                        ->action(fn (Collection $records) => $records->each->update(['approved_at' => now(), 'declined_at' => null]))
+                        ->action(fn (Collection $records) => $records->each->update(['approved_at' => now()]))
                         ->deselectRecordsAfterCompletion()
                         ->requiresConfirmation()
                         ->modalIcon('heroicon-s-check')
                         ->modalHeading('Approuver')
                         ->modalSubheading('Voulez-vous vraiment approuver ces articles ?')
                         ->modalButton('Confirmer'),
                     BulkAction::make('declined')
+                        ->visible(fn (?Collection $records) => ! empty($records) || $records?->contains(fn ($record) => $record->submitted_at))
                         ->label('Décliner la sélection')
                         ->icon('heroicon-s-x-mark')
                         ->color('warning')
-                        ->action(fn (Collection $records) => $records->each->update(['declined_at' => now(), 'approved_at' => null]))
+                        ->action(fn (Collection $records) => $records->each->update(['declined_at' => now()]))
                         ->deselectRecordsAfterCompletion()
                         ->requiresConfirmation()
                         ->modalIcon('heroicon-s-x-mark')

tests/Feature/Filament/ArticleTest.php

@@ -57,25 +57,4 @@
             ->and($article->approved_at)
             ->toBe(null);
     });
-
-    it('admin user can bulk approved articles', function (): void {
-        $articles = Article::factory()->count(5)->create(['submitted_at' => now()]);
-
-        Livewire::test(ArticleResource\Pages\ListArticles::class)
-            ->callTableBulkAction('approved', $articles);
-
-        expect(Article::whereNotNull('approved_at')->count())
-            ->toBe(5);
-    });
-
-    it('admin user can bulk declined articles', function (): void {
-        $articles = Article::factory()->count(5)->create(['submitted_at' => now()]);
-
-        Livewire::test(ArticleResource\Pages\ListArticles::class)
-            ->callTableBulkAction('declined', $articles);
-
-        expect(Article::whereNotNull('declined_at')->count())
-            ->toBe(5);
-    });
-
 })->group('articles');