Feat/pydantic#6
Closed
romaingrx wants to merge 367 commits into
Closed
Conversation
…d_adjacency and split_species functions
…onnected_groups function in Metal class
…rix in Specie class
…_reference_molecules function Cell class
- Removed the cell2mol_mode function from final_c2m_module.py, simplifying the interface for running cell2mol. - Consolidated the unit cell reconstruction logic into a new function, reconstruct_unitcell, in cell_reconstruction.py. - Updated unitcell.py to directly call reconstruct_unitcell, enhancing clarity and reducing complexity.
…plex molecules WIP
feat: add ProtonationGroupResult to type registry
- Introduced a new script `rf.py` for training a Random Forest classifier. - Added hapticity in features - Included cross-validation for model evaluation with metrics such as accuracy and F1 score. - Saved the trained model and its metadata, including feature importance.
- enumerate protonation states - resolve charge states for species - balance and validate total molecular or unit cell charge - process SMILES and generate bond order information
- Updated logging messages in Group and Ligand classes to provide clearer context. - Removed debug parameters from methods where they were unnecessary. - Changed import paths for charge-related functions to reflect new module structure. - Simplified charge assignment logic in Molecule class and removed redundant debug prints. - Enhanced error assessment in Molecule class to categorize error cases. - Cleaned up commented-out debug logs for better readability. - Adjusted default values for cov_factor and metal_factor in Specie class to use config constants.
…s and numpy arrays
…ecify protonation type
…nd unitcell attributes
… and connected atoms
…t attribute and computed properties
Co-authored-by: Copilot <copilot@github.com>
… SMILES processing
… resonance structure evaluation
…rove resonance structure handling
…in macrocycle identification
…or porphyrins and fullerene handling
…erenes, noble gases, teflate, and Sb-halides These species were previously skipped or forced through the general AC2mol bond-order search, which either can't scale to them (60+ atom fullerene cages) or produces chemically implausible charge-separated resonance structures. Each now gets a direct, connectivity-based charge assignment instead: - Fullerene cages: closed-shell Kekule structure via a perfect matching on the 3-regular cage graph (Petersen's theorem), replacing the old "skip entirely" behavior. - Noble gas solvate/lattice atoms: always neutral. - Teflate (-OTeF5): fixed hexacoordinate Te(VI) pattern with charge on the terminal O. - Sb-halide-only species: per-center formal charge for mononuclear cases, and charge distributed round-robin across terminal halogens for polynuclear/bridged clusters. Also: - Route As/Sb/Bi/Se/Te always through the AC2BO search regardless of whether their degree matches a "normal" valence. - Detect non-coordinated carboxylate/sulfonate moieties to size ligand max-charge ranges, replacing the plain terminal-oxygen count. - Add dedicated porphyrin charge handling and disable charged fragments when a porphyrin's candidate charge is 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.